[WIP] Add WithoutVector option for VectorRequest to make correction faster

apis/grpc/v1/payload/payload_vtproto.pb.go

@@ -854,8 +854,9 @@ func (m *Object_VectorRequest) CloneVT() *Object_VectorRequest {
 		return (*Object_VectorRequest)(nil)
 	}
 	r := &Object_VectorRequest{
-		Id:      m.Id.CloneVT(),
-		Filters: m.Filters.CloneVT(),
+		Id:            m.Id.CloneVT(),
+		Filters:       m.Filters.CloneVT(),
+		WithoutVector: m.WithoutVector,
 	}
 	if len(m.unknownFields) > 0 {
 		r.unknownFields = make([]byte, len(m.unknownFields))
@@ -2775,6 +2776,9 @@ func (this *Object_VectorRequest) EqualVT(that *Object_VectorRequest) bool {
 	if !this.Filters.EqualVT(that.Filters) {
 		return false
 	}
+	if this.WithoutVector != that.WithoutVector {
+		return false
+	}
 	return string(this.unknownFields) == string(that.unknownFields)
 }
 
@@ -5848,6 +5852,16 @@ func (m *Object_VectorRequest) MarshalToSizedBufferVT(dAtA []byte) (int, error)
 		i -= len(m.unknownFields)
 		copy(dAtA[i:], m.unknownFields)
 	}
+	if m.WithoutVector {
+		i--
+		if m.WithoutVector {
+			dAtA[i] = 1
+		} else {
+			dAtA[i] = 0
+		}
+		i--
+		dAtA[i] = 0x18
+	}
 	if m.Filters != nil {
 		size, err := m.Filters.MarshalToSizedBufferVT(dAtA[:i])
 		if err != nil {
@@ -8436,6 +8450,9 @@ func (m *Object_VectorRequest) SizeVT() (n int) {
 		l = m.Filters.SizeVT()
 		n += 1 + l + sov(uint64(l))
 	}
+	if m.WithoutVector {
+		n += 2
+	}
 	n += len(m.unknownFields)
 	return n
 }
@@ -13272,6 +13289,26 @@ func (m *Object_VectorRequest) UnmarshalVT(dAtA []byte) error {
 				return err
 			}
 			iNdEx = postIndex
+		case 3:
+			if wireType != 0 {
+				return fmt.Errorf("proto: wrong wireType = %d for field WithoutVector", wireType)
+			}
+			var v int
+			for shift := uint(0); ; shift += 7 {
+				if shift >= 64 {
+					return ErrIntOverflow
+				}
+				if iNdEx >= l {
+					return io.ErrUnexpectedEOF
+				}
+				b := dAtA[iNdEx]
+				iNdEx++
+				v |= int(b&0x7F) << shift
+				if b < 0x80 {
+					break
+				}
+			}
+			m.WithoutVector = bool(v != 0)
 		default:
 			iNdEx = preIndex
 			skippy, err := skip(dAtA[iNdEx:])

apis/proto/v1/payload/payload.proto

@@ -337,6 +337,8 @@ message Object {
     ID id = 1 [(validate.rules).repeated.min_items = 2];
     // Filter configurations.
     Filter.Config filters = 2;
+    // Only fetch the vector id and timestamp
+    bool without_vector = 3;
   }
 
   // Represent the ID and distance pair.

apis/swagger/v1/vald/apis/proto/v1/vald/object.swagger.json

@@ -90,6 +90,13 @@
             "in": "path",
             "required": true,
             "type": "string"
+          },
+          {
+            "name": "withoutVector",
+            "description": "Only fetch the vector id and timestamp.",
+            "in": "query",
+            "required": false,
+            "type": "boolean"
           }
         ],
         "tags": ["Object"]

pkg/agent/core/ngt/handler/grpc/object.go

@@ -124,8 +124,10 @@ func (s *server) GetObject(ctx context.Context, id *payload.Object_VectorRequest
 	}
 	res = payload.Object_VectorFromVTPool()
 	res.Id = uuid
-	res.Vector = vec
 	res.Timestamp = ts
+	if !id.GetWithoutVector() {
+		res.Vector = vec
+	}
 	return res, nil
 }
 

pkg/index/job/correction/service/corrector.go

@@ -297,6 +297,9 @@
 				Id: &payload.Object_ID{
 					Id: targetReplica.vec.GetId(),
 				},
+				// FIXME: To make the processing faster. We can do this because there's no need to get the vector itself to detect inconsistency.
+				// If a vector turned out to be corrected, then we need to get the vector again with the vector data.
+				WithoutVector: true,
 			})
 			if err != nil {
 				if st, ok := status.FromError(err); !ok {