Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor from deepsource feedback (Continuous Benchmark codes) #2219

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Oct 25, 2023

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.21.3
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.2
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 25, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 57f3ac6
Status: ✅  Deploy successful!
Preview URL: https://cd3cc56b.vald.pages.dev
Branch Preview URL: https://refactor-internal-pkg-refact.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vankichi vankichi force-pushed the refactor/internal-pkg/refactor-by-deepsource-feedback branch from 4288e07 to 57f3ac6 Compare October 25, 2023 07:47
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
internal/sync/errgroup/group.go 89.00% <ø> (ø)
pkg/tools/benchmark/operator/service/operator.go 64.48% <88.88%> (-0.15%) ⬇️
pkg/tools/benchmark/operator/service/option.go 11.42% <0.00%> (ø)

... and 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@vankichi vankichi changed the title [WIP] Refactor from deepsource feedback Refactor from deepsource feedback (Continuous Benchmark codes) Oct 26, 2023
@vankichi vankichi merged commit f93c88a into feature/continuous-benchmark Oct 30, 2023
82 checks passed
@vankichi vankichi deleted the refactor/internal-pkg/refactor-by-deepsource-feedback branch October 30, 2023 04:24
@vankichi vankichi mentioned this pull request Oct 30, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants