Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix lb gateway pacicked caused by pairing heap search aggregator makes nil pointer when empty search result #2181

Merged
merged 1 commit into from
Sep 14, 2023
Merged

bugfix lb gateway pacicked caused by pairing heap search aggregator makes nil pointer when empty search result #2181

merged 1 commit into from
Sep 14, 2023

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Sep 14, 2023 •
edited
Loading

Description:

SSIA
Please review pkg/gateway/lb/handler/grpc/aggregation.go only.

Related Issue:

Versions:

  • Go Version: 1.21.1
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.1
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

@kpango
bugfix lb gateway pacicked caused by pairing heap search aggregator m…
1b5b1f0 
…akes nil pointer when empty search result

Signed-off-by: kpango <[email protected]>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vankichi vankichi merged commit 49d3b28 into main Sep 14, 2023
67 of 68 checks passed
@vankichi vankichi deleted the bugfix/gateway/nil-pointer-when-no-search-result branch September 14, 2023 03:15
@hlts2 hlts2 mentioned this pull request Sep 14, 2023
Merged
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Bugfix lb gateway pacicked caused by pairing heap search aggr…
213b2a0 
…egator makes nil pointer when empty search result (#2181)"

This reverts commit 49d3b28.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Bugfix lb gateway pacicked caused by pairing heap search aggr…
e829ea6 
…egator makes nil pointer when empty search result (#2181)"

This reverts commit 49d3b28.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Bugfix lb gateway pacicked caused by pairing heap search aggr…
2bdd011 
…egator makes nil pointer when empty search result (#2181)"

This reverts commit 49d3b28.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Bugfix lb gateway pacicked caused by pairing heap search aggr…
961dc6d 
…egator makes nil pointer when empty search result (#2181)"

This reverts commit 49d3b28.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Bugfix lb gateway pacicked caused by pairing heap search aggr…
61ee9de 
…egator makes nil pointer when empty search result (#2181)"

This reverts commit 49d3b28.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Bugfix lb gateway pacicked caused by pairing heap search aggr…
1159041 
…egator makes nil pointer when empty search result (#2181)"

This reverts commit 49d3b28.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Bugfix lb gateway pacicked caused by pairing heap search aggr…
1421e85 
…egator makes nil pointer when empty search result (#2181)"

This reverts commit 49d3b28.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Bugfix lb gateway pacicked caused by pairing heap search aggr…
42f6562 
…egator makes nil pointer when empty search result (#2181)"

This reverts commit 49d3b28.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Bugfix lb gateway pacicked caused by pairing heap search aggr…
4dfb478 
…egator makes nil pointer when empty search result (#2181)"

This reverts commit 49d3b28.
kmrmt pushed a commit that referenced this pull request Dec 12, 2023
@kpango @kmrmt
Bugfix lb gateway pacicked caused by pairing heap search aggregator m…
e12acfe 
…akes nil pointer when empty search result (#2181)

Signed-off-by: kpango <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlts2 hlts2 hlts2 approved these changes

@vankichi vankichi vankichi approved these changes

Assignees
No one assigned
Labels
area/agent/core area/agent/sidecar area/discoverer area/gateway/filter area/gateway/lb area/manager/index priority/medium size/M type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpango @vdaas-ci @vankichi @hlts2