Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add benchmark and check program for core ngt #2179

Merged
merged 13 commits into from
Dec 4, 2023
Merged

add benchmark and check program for core ngt #2179

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
130f731
add core ngt benchmark
kpango Oct 18, 2023
477a4f6
add finalizer for pooling
kpango Oct 19, 2023
3a8f3bb
fix benchmark
kmrmt Oct 30, 2023
75d15f6
fix test
kmrmt Oct 30, 2023
4661b21
fix test
kmrmt Oct 30, 2023
182b2bc
fix test
kmrmt Oct 30, 2023
110efce
fix reviewdog report
kmrmt Oct 31, 2023
02b0b5f
fix reviewdog report
kmrmt Oct 31, 2023
52eb1c4
fix deepsource report
kmrmt Nov 1, 2023
c10d65c
fix according to comments
kmrmt Nov 8, 2023
af069b8
Merge branch 'main' into feature/benchmark/add-benchmark-core-ngt
kpango Nov 12, 2023
7592fa3
Merge branch 'main' into feature/benchmark/add-benchmark-core-ngt
kpango Nov 16, 2023
d75690f
Merge branch 'main' into feature/benchmark/add-benchmark-core-ngt
kpango Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions charts/vald-helm-operator/crds/valdrelease.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,9 @@ spec:
type: boolean
enable_proactive_gc:
type: boolean
error_buffer_limit:
type: integer
minimum: 1
index_path:
type: string
initial_delay_max_duration:
Expand Down
1 change: 1 addition & 0 deletions charts/vald/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ Run the following command to install the chart,
| agent.ngt.enable_copy_on_write | bool | `false` | enable copy on write saving for more stable backup |
| agent.ngt.enable_in_memory_mode | bool | `true` | in-memory mode enabled |
| agent.ngt.enable_proactive_gc | bool | `false` | enable proactive GC call for reducing heap memory allocation |
| agent.ngt.error_buffer_limit | int | `10` | maximum number of core ngt error buffer pool size limit |
| agent.ngt.index_path | string | `""` | path to index data |
| agent.ngt.initial_delay_max_duration | string | `"3m"` | maximum duration for initial delay |
| agent.ngt.kvsdb.concurrency | int | `6` | kvsdb processing concurrency |
Expand Down
5 changes: 5 additions & 0 deletions charts/vald/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,11 @@
"type": "boolean",
"description": "enable proactive GC call for reducing heap memory allocation"
},
"error_buffer_limit": {
"type": "integer",
"description": "maximum number of core ngt error buffer pool size limit",
"minimum": 1
},
"index_path": {
"type": "string",
"description": "path to index data"
Expand Down
3 changes: 3 additions & 0 deletions charts/vald/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1723,6 +1723,9 @@ agent:
# @schema {"name": "agent.ngt.broken_index_history_limit", "type": "integer", "minimum": 0}
# agent.ngt.broken_index_history_limit -- maximum number of broken index generations to backup
broken_index_history_limit: 0
# @schema {"name": "agent.ngt.error_buffer_limit", "type": "integer", "minimum": 1}
# agent.ngt.error_buffer_limit -- maximum number of core ngt error buffer pool size limit
error_buffer_limit: 10
# @schema {"name": "agent.sidecar", "type": "object"}
sidecar:
# @schema {"name": "agent.sidecar.enabled", "type": "boolean"}
Expand Down
Loading
Loading