Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Agent #2172

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Refactor Agent #2172

merged 2 commits into from
Sep 11, 2023

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Sep 8, 2023

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.21.0
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.1
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 8, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited
Loading

Codecov Report

Patch coverage is 20.58% of modified lines.

❗ Current head 29745df differs from pull request most recent head 0b7e290. Consider uploading reports for the commit 0b7e290 to get more accurate results

Files Changed Coverage
hack/benchmark/internal/operation/search.go 0.00%
internal/errors/ngt.go ø
pkg/agent/core/ngt/handler/grpc/linear_search.go 0.00%
pkg/agent/core/ngt/handler/grpc/search.go 0.00%
pkg/agent/core/ngt/service/ngt.go 33.33%
internal/core/algorithm/ngt/ngt.go 38.46%

📢 Thoughts on this report? Let us know!.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 8, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0b7e290
Status: ✅  Deploy successful!
Preview URL: https://3a4707d0.vald.pages.dev
Branch Preview URL: https://refactor-internal-add-free-o.vald.pages.dev

View logs

@kpango kpango force-pushed the refactor/internal/add-free-operations-for-ngt-cgo branch 4 times, most recently from 2ed9d17 to faa3f10 Compare September 8, 2023 06:35
@github-actions github-actions bot added size/L and removed size/M labels Sep 8, 2023
@kpango kpango force-pushed the refactor/internal/add-free-operations-for-ngt-cgo branch from faa3f10 to b07ae04 Compare September 8, 2023 09:03
@kpango kpango force-pushed the refactor/internal/add-free-operations-for-ngt-cgo branch 4 times, most recently from 828d58e to 4555691 Compare September 8, 2023 15:19
@github-actions github-actions bot added the team/set SET team label Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/refactor%2Finternal%2Fadd-free-operations-for-ngt-cgo/40610ac8168c9a1bbbe6a18047109217e0917e4f

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 8, 2023

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

@kpango kpango force-pushed the refactor/internal/add-free-operations-for-ngt-cgo branch 2 times, most recently from f680dff to 33a6841 Compare September 9, 2023 02:24
@github-actions github-actions bot added the team/sre SRE team label Sep 9, 2023
@kpango kpango marked this pull request as ready for review September 11, 2023 01:27
@kpango kpango force-pushed the refactor/internal/add-free-operations-for-ngt-cgo branch from 6324238 to 665cd35 Compare September 11, 2023 01:50
@kpango kpango force-pushed the refactor/internal/add-free-operations-for-ngt-cgo branch from 665cd35 to 947ff40 Compare September 11, 2023 01:52
vankichi
vankichi previously approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango requested a review from kevindiu September 11, 2023 02:43
kevindiu
kevindiu previously approved these changes Sep 11, 2023
View reviewed changes
@kpango kpango dismissed stale reviews from kevindiu and vankichi via 29745df September 11, 2023 04:37
vankichi
vankichi previously approved these changes Sep 11, 2023
View reviewed changes
@kpango kpango force-pushed the refactor/internal/add-free-operations-for-ngt-cgo branch from 29745df to 0b7e290 Compare September 11, 2023 05:01
@kpango kpango requested review from kevindiu and vankichi September 11, 2023 05:02
@kpango kpango merged commit 69960f8 into main Sep 11, 2023
60 of 62 checks passed
@kpango kpango deleted the refactor/internal/add-free-operations-for-ngt-cgo branch September 11, 2023 05:04
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
Merged
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Refactor agent ngt core. (#2172)"
25978b6 
This reverts commit 69960f8.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Refactor agent ngt core. (#2172)"
d1681ef 
This reverts commit 69960f8.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Refactor agent ngt core. (#2172)"
2e6ff8c 
This reverts commit 69960f8.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Refactor agent ngt core. (#2172)"
1484815 
This reverts commit 69960f8.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Refactor agent ngt core. (#2172)"
eebf75c 
This reverts commit 69960f8.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Refactor agent ngt core. (#2172)"
dd5e31a 
This reverts commit 69960f8.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Refactor agent ngt core. (#2172)"
3060f66 
This reverts commit 69960f8.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Refactor agent ngt core. (#2172)"
7126bb1 
This reverts commit 69960f8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vankichi vankichi vankichi approved these changes

@kevindiu kevindiu kevindiu approved these changes

Assignees
No one assigned
Labels
actions/e2e-chaos actions/e2e-deploy actions/e2e-max-dim actions/e2e-profiling actions/fossa area/agent/core area/internal priority/low size/L team/set SET team team/sre SRE team type/ci type/refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpango @vdaas-ci @kevindiu @vankichi