Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two version deploy support #2171

Merged
merged 50 commits into from
Jan 10, 2024
Merged

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Sep 7, 2023

Description:

In this PR, it includes a change to support 2 version deploy.
The workflow related to the 2 version deploy is as below.

  • semver-major-minor.yaml
    • This workflow creates a release PR when there is a major/minor related commit.
  • semver-patch.yaml
    • The workflow is to create a release PR when there is a commit related to patch.
  • _release-pr.yml
    • This is a reusable workflow. When this is called, update the charts, k8s, ...etc with the corresponding semantic version and create a release PR.
  • release.yml
    • This is the workflow for the actual release when the release PRs are merged.
  • backport.yml
    • This is the workflow for backporting a feature: if a label like actions/backport/main, actions/backport/release/v1.8 exists in the PR, vdaas-ci creates a new PR to another branch (main, release/v1.8) with squash merge commit.
  • determine-docker-image-tag/action.yaml
    • The docker image tag is important in realizing the 2 version deploy. Since we have created actions to determine the docker tag in the previous PR, the logic around the image tag is included here. We can get the proper docker image tag considering the current branch.
  • _detect-ci-container.yml
    • This is a reusable workflow. This allows us to dynamically change the image tags of ci-container.

Related Issue:

Versions:

  • Go Version: 1.21.0
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.1
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 7, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 7, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3d12458
Status: ✅  Deploy successful!
Preview URL: https://d992a62b.vald.pages.dev
Branch Preview URL: https://feature-ci-two-version-deplo.vald.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 7, 2023

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

datelier
datelier previously approved these changes Dec 19, 2023
ykadowak
ykadowak previously approved these changes Dec 19, 2023
vankichi
vankichi previously approved these changes Dec 19, 2023
kpango
kpango previously approved these changes Dec 20, 2023
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kmrmt
kmrmt previously approved these changes Dec 21, 2023
@hlts2 hlts2 dismissed stale reviews from ykadowak, datelier, vankichi, kpango, and kmrmt via 3d12458 January 9, 2024 02:35
@hlts2
Copy link
Collaborator Author

hlts2 commented Jan 9, 2024

Thank you for your previous review 🙏
Sorry, I updated the license header and the approval disappeared....
There is no change to the logic.

@vankichi vankichi merged commit 174969a into main Jan 10, 2024
108 of 109 checks passed
@vankichi vankichi deleted the feature/ci/two-version-deploy-support branch January 10, 2024 05:06
This was referenced Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants