-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor agent GetObject error not to wrap with details for performance issue #2154
Conversation
[CHATOPS:HELP] ChatOps commands.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2154 +/- ##
==========================================
- Coverage 31.18% 31.13% -0.05%
==========================================
Files 339 339
Lines 32920 32901 -19
==========================================
- Hits 10266 10244 -22
+ Misses 22202 22200 -2
- Partials 452 457 +5
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
This PR removes error details from agent
GetObject
andExists
rpc error. This is required because the following performance issue was discovered while developing theindex correction
feature.The issues is that when the client issues a large number of
GetObject
to the agent, the process of the http2 client huffman decoding the error detail from the header becomes a bottleneck in CPU processing, resulting in a decrease of QPS. Same goes toExists
.Even if this error detail is removed, its impact is considered to be minor. This is because it only affects the use case of the agent standalone, which is limited. Also, even in that case, the client side can manage the error without details because it must be a unary request, not stream, to the agent.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: