Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timestamp check for GetObject e2e #2142

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Add timestamp check for GetObject e2e #2142

merged 2 commits into from
Jul 27, 2023

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented Jul 26, 2023 •
edited
Loading

Description:

Adds the e2e check if the server returns timestamp properly when GetObject rpc called.
Follow up on #2136

Related Issue:

Versions:

  • Go Version: 1.20.6
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.16

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@ykadowak ykadowak requested review from a team, kevindiu and hlts2 and removed request for a team July 26, 2023 06:29
kpango
kpango approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 26, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7eb40ad
Status: ✅  Deploy successful!
Preview URL: https://3f8964ac.vald.pages.dev
Branch Preview URL: https://feature-timestamp-e2e.vald.pages.dev

View logs

@ykadowak ykadowak merged commit c58cc15 into main Jul 27, 2023
@ykadowak ykadowak deleted the feature/timestamp-e2e branch July 27, 2023 01:40
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
Merged
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "add timestamp check for GetObject e2e (#2142)"
6e52762 
This reverts commit c58cc15.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "add timestamp check for GetObject e2e (#2142)"
6dc6bcf 
This reverts commit c58cc15.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "add timestamp check for GetObject e2e (#2142)"
4674e5d 
This reverts commit c58cc15.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "add timestamp check for GetObject e2e (#2142)"
0cbc442 
This reverts commit c58cc15.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpango kpango kpango approved these changes

@kevindiu kevindiu kevindiu approved these changes

@hlts2 hlts2 Awaiting requested review from hlts2 hlts2 was automatically assigned from vdaas/maintainer

Assignees
No one assigned
Labels
actions/e2e-deploy priority/medium size/M type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykadowak @vdaas-ci @kevindiu @kpango