Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate context to Search operation. #2117

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Jul 11, 2023

Description:

WHAT

I fixed to propagate context to Search operation.

WHY

When Search operation is taking a long time, it cannot be interrupted because the Context is not propagated,

Related Issue:

Versions:

  • Go Version: 1.20.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.13

Checklist:

Special notes for your reviewer:

@hlts2 hlts2 changed the title Add search context to agent ngt service Propagate context to Search operation. Jul 11, 2023
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 11, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f029ca3
Status: ✅  Deploy successful!
Preview URL: https://4660257c.vald.pages.dev
Branch Preview URL: https://bugfix-agent-add-search-cont.vald.pages.dev

View logs

@github-actions github-actions bot added team/set SET team size/L and removed size/M labels Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 62.50% and project coverage change: -0.50 ⚠️

Comparison is base (e52eb4a) 31.13% compared to head (ee4445f) 30.64%.

❗ Current head ee4445f differs from pull request most recent head f029ca3. Consider uploading reports for the commit f029ca3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2117      +/-   ##
==========================================
- Coverage   31.13%   30.64%   -0.50%     
==========================================
  Files         339      335       -4     
  Lines       32791    31291    -1500     
==========================================
- Hits        10211     9589     -622     
+ Misses      22131    21357     -774     
+ Partials      449      345     -104     
Impacted Files Coverage Δ
internal/core/algorithm/ngt/ngt.go 62.09% <50.00%> (-0.89%) ⬇️
pkg/agent/core/ngt/handler/grpc/search.go 23.10% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hlts2 hlts2 force-pushed the bugfix/agent/add-search-context branch from d9fe927 to f029ca3 Compare July 11, 2023 10:05
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@kpango kpango merged commit 0bdc7ae into main Jul 11, 2023
@kpango kpango deleted the bugfix/agent/add-search-context branch July 11, 2023 11:11
ykadowak pushed a commit that referenced this pull request Jul 25, 2023
* add search context to agent service

Signed-off-by: hlts2 <[email protected]>

* fix test execution error

Signed-off-by: hlts2 <[email protected]>

* fix build error of ngt stateful test

Signed-off-by: hlts2 <[email protected]>

---------

Signed-off-by: hlts2 <[email protected]>
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants