add faiss debug option #2113
Merged
add faiss debug option #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datelier
requested review from
a team,
kmrmt and
kevindiu
and removed request for
a team
|
[CHATOPS:HELP] ChatOps commands.
|
kmrmt
approved these changes
Jul 6, 2023
Comment on lines
34
to
38
| #if DEBUG | ||
| printf(__FUNCTION__); | ||
| printf("\n"); | ||
| fflush(stdout); | ||
| #endif |
There was a problem hiding this comment.
Suggested change
| #if DEBUG | |
| printf(__FUNCTION__); | |
| printf("\n"); | |
| fflush(stdout); | |
| #endif | |
| #if DEBUG | |
| printf("%s\n", __FUNCTION__); | |
| fflush(stdout); | |
| #endif |
You can use some macros such as __PRETTY_FUNCTION__ and __LINE__ for detail debug message.
FYI, there is one of some debugging techniques like below.
#ifdef DEBUG
#define DEBUG_MESSAGE(x) do { std::cout << "[" << __FUNCTION__ << ":" << __LINE__ << "]" << x << std::endl; } while(0)
#else
#define DEBUG_MESSAGE(x)
#endif
ykadowak
reviewed
Jul 7, 2023
Deploying with
|
| Latest commit: |
d734257
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b5e763a7.vald.pages.dev |
| Branch Preview URL: | https://feature-agent-faiss.vald.pages.dev |
ykadowak
approved these changes
Jul 10, 2023
kevindiu
approved these changes
Jul 11, 2023
kpango
added a commit
that referenced
this pull request
Jul 15, 2023
add faiss debug option modify to constexpr bool Merge pull request #2113 from vdaas/feature/agent/faiss Signed-off-by: kpango <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
SSIA
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: