[WIP] Feature/internal/sync map #2109
+238
−238
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,25 +26,25 @@ import ( | |
| "github.com/vdaas/vald/internal/errors" | ||
| ) | ||
|
|
||
| type cache[V any] struct { | ||
| cacher cacher.Type | ||
| expireDur time.Duration | ||
| expireCheckDur time.Duration | ||
| expiredHook func(context.Context, string) | ||
| } | ||
|
|
||
| // New returns the Cache instance or error. | ||
| func New[V any](opts ...Option[V]) (cc cacher.Cache[V], err error) { | ||
| c := new(cache[V]) | ||
|
There was a problem hiding this comment. 🚫 [golangci] reported by reviewdog 🐶 |
||
| for _, opt := range append(defaultOptions[V](), opts...) { | ||
| opt(c) | ||
| } | ||
| switch c.cacher { | ||
| case cacher.GACHE: | ||
| return gache.New[V]( | ||
| gache.WithExpireDuration[V](c.expireDur), | ||
| gache.WithExpireCheckDuration[V](c.expireCheckDur), | ||
| gache.WithExpiredHook[V](c.expiredHook), | ||
| ), nil | ||
| default: | ||
| return nil, errors.ErrInvalidCacherType | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,21 +21,21 @@ import ( | |
| "context" | ||
| "time" | ||
|
|
||
| gache "github.com/kpango/gache/v2" | ||
| "github.com/vdaas/vald/internal/cache/cacher" | ||
| ) | ||
|
|
||
| type cache[V any] struct { | ||
| gache gache.Gache[V] | ||
|
There was a problem hiding this comment. 🚫 [golangci] reported by reviewdog 🐶 |
||
| expireDur time.Duration | ||
| expireCheckDur time.Duration | ||
| expiredHook func(context.Context, string) | ||
| } | ||
|
|
||
| // New loads a cache model and returns a new cache struct. | ||
| func New[V any](opts ...Option[V]) cacher.Cache[V] { | ||
| c := new(cache[V]) | ||
| for _, opt := range append(defaultOptions[V](), opts...) { | ||
| opt(c) | ||
| } | ||
| c.gache.SetDefaultExpire(c.expireDur) | ||
|
|
@@ -48,31 +48,31 @@ func New(opts ...Option) cacher.Cache { | |
| } | ||
|
|
||
| // Start calls StartExpired func of c.gache. | ||
| func (c *cache[V]) Start(ctx context.Context) { | ||
| c.gache.StartExpired(ctx, c.expireCheckDur) | ||
| } | ||
|
|
||
| // Get calls StartExpired func of c.gache and returns (interface{}, bool) according to key. | ||
| func (c *cache[V]) Get(key string) (V, bool) { | ||
|
There was a problem hiding this comment. 🚫 [golangci] reported by reviewdog 🐶 |
||
| return c.gache.Get(key) | ||
| } | ||
|
|
||
| // Set calls Set func of c.gache. | ||
| func (c *cache[V]) Set(key string, val V) { | ||
| c.gache.Set(key, val) | ||
| } | ||
|
|
||
| // Delete calls Delete func of c.gache. | ||
| func (c *cache[V]) Delete(key string) { | ||
| c.gache.Delete(key) | ||
| } | ||
|
|
||
| // GetAndDelete returns (interface{}, bool) and delete value according to key when value of key is set. | ||
| // When value of key is not set, returns (nil, false). | ||
| func (c *cache[V]) GetAndDelete(key string) (V, bool) { | ||
|
There was a problem hiding this comment. 🚫 [golangci] reported by reviewdog 🐶 |
||
| v, ok := c.gache.Get(key) | ||
| if !ok { | ||
| return *new(V), false | ||
| } | ||
| c.gache.Delete(key) | ||
| return v, true | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
named return "cc" with type "cacher.Cache[V]" found (nonamedreturns)