Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

divide latency of CreateIndex and SaveIndex metrics #2099

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

kmrmt
Copy link
Contributor

@kmrmt kmrmt commented Jun 29, 2023

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.20.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.13

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kmrmt kmrmt force-pushed the feature/metrics/divide-agent-metrics branch from 4c77369 to 91b8620 Compare June 30, 2023 11:14
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 30, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 935101a
Status:⚡️  Build in progress...

View logs

@kmrmt kmrmt force-pushed the feature/metrics/divide-agent-metrics branch from 91b8620 to 0a07058 Compare June 30, 2023 11:16
@kmrmt kmrmt requested review from a team, kpango and vankichi and removed request for a team July 3, 2023 04:32
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 6cc01a5 into main Jul 11, 2023
@kpango kpango deleted the feature/metrics/divide-agent-metrics branch July 11, 2023 16:52
ykadowak pushed a commit that referenced this pull request Jul 25, 2023
* divide latency of CreateIndex and SaveIndex metrics

Signed-off-by: Kosuke Morimoto <[email protected]>

* divide latency of CreateIndex and SaveIndex Vald Agent metrics

Signed-off-by: Kosuke Morimoto <[email protected]>

---------

Signed-off-by: Kosuke Morimoto <[email protected]>
Co-authored-by: Yusuke Kato <[email protected]>
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants