add user custom network policy #2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
area/helm
size/S
type/feature
Deploying with
|
| Latest commit: |
3798457
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cbefc5db.vald.pages.dev |
| Branch Preview URL: | https://feature-charts-custom-networ.vald.pages.dev |
Profile Report
|
ykadowak
changed the title
ykadowak
requested review from
a team,
kmrmt and
vankichi
and removed request for
a team
kmrmt
approved these changes
Jun 21, 2023
vankichi
approved these changes
Jun 21, 2023
ykadowak
added a commit
that referenced
this pull request
Jun 26, 2023
* add user custom network policy template * add appPort to access grafana from host * add kube-system as egress allow for agent * add network policy settings as an example * add stern in dev container * add schema comments * add network policy enabled to ci helm values * add cluster role to deploy network policy * style: Format code with prettier and gofumpt * remove unnecesary network policy ci settings * add pyroscope to ingress rule --------- Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With this PR, a vald user can add their own network policy on top of the default one that was added with #2022. This is required, for example, when a vald user needs to configure observability components with network policy enabled (an example below).
vald/charts/vald/values/dev-observability.yaml
Lines 45 to 50 in 73cc0a6
In addition to helm templates change, these changes also have been made,
e2e-deploytests to to verify the deploy and communication between each component with the default network policy settings.Related Issue:
Versions:
Checklist:
Special notes for your reviewer: