refactor and add test for service/ngt.go #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
Deploying with
|
| Latest commit: |
0c1b1f8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://04006ad8.vald.pages.dev |
| Branch Preview URL: | https://feature-agent-refactor-new.vald.pages.dev |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2040 +/- ##
==========================================
+ Coverage 29.44% 29.51% +0.06%
==========================================
Files 366 366
Lines 34625 34634 +9
==========================================
+ Hits 10197 10223 +26
+ Misses 24001 23974 -27
- Partials 427 437 +10
☔ View full report in Codecov by Sentry. |
|
[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/feature%2Fagent%2Frefactor-new/94e5299a726668a04a74d6f429ebc15dd4f074fe |
Profile Report
|
ykadowak
changed the title
ykadowak
commented
May 25, 2023
ykadowak
requested review from
kpango,
a team and
vankichi
and removed request for
a team
kpango
reviewed
May 25, 2023
kpango
reviewed
May 25, 2023
Co-authored-by: Yusuke Kato <[email protected]>
vankichi
approved these changes
May 25, 2023
Profile Report
|
kevindiu
approved these changes
May 26, 2023
This was referenced Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As a preparation for #2034, extracted the process of initializing the backup folder and added some tests.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: