[Bugfix] remove sudo from kubectl/install make command and small refactor around os/arch #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
area/makefile
team/sre
kpango
force-pushed
the
bugfix/tools/remove-sudo-from-kubectl-install
branch
from
c465e22 to
eda6ddc
Compare
Deploying with
|
| Latest commit: |
abab3f1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dc4af1b7.vald.pages.dev |
| Branch Preview URL: | https://bugfix-tools-remove-sudo-fro.vald.pages.dev |
kpango
changed the title
kpango
requested review from
a team,
vankichi and
hlts2
and removed request for
a team
kpango
force-pushed
the
bugfix/tools/remove-sudo-from-kubectl-install
branch
from
eda6ddc to
489a010
Compare
kpango
force-pushed
the
bugfix/tools/remove-sudo-from-kubectl-install
branch
from
489a010 to
a5b09de
Compare
kpango
force-pushed
the
bugfix/tools/remove-sudo-from-kubectl-install
branch
from
a5b09de to
924bb17
Compare
Signed-off-by: kpango <[email protected]>
kpango
force-pushed
the
bugfix/tools/remove-sudo-from-kubectl-install
branch
from
924bb17 to
abab3f1
Compare
kpango
added
actions/e2e-deploy
actions/fossa
actions/e2e-chaos
actions/e2e-profiling
actions/e2e-max-dim
and removed
actions/e2e-chaos
labels
|
[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/bugfix%2Ftools%2Fremove-sudo-from-kubectl-install/80693e6fd0b6f30a0ea7954938680a2d6802a993 |
Profile Report
|
vankichi
approved these changes
May 24, 2023
ykadowak
approved these changes
May 24, 2023
|
To disabling the DeepSource-TestCoverage, we have to |
👍 |
This was referenced Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixed CI Container build failure due to use of sudo in kubectl/install in the Makefile.
And refactored redundant OS/Arch switches.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: