Fix incorrect error output of gen-test chatopts command #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kevindiu <[email protected]>
kevindiu
changed the title
|
/gen-test |
|
[CHATOPS:HELP] ChatOps commands.
|
|
[GEN TEST] Generating missing test files triggered by kevindiu. |
Deploying with
|
| Latest commit: |
29101a8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ec62fd7c.vald.pages.dev |
| Branch Preview URL: | https://ci-fix-chatopts-gen-test-com.vald.pages.dev |
|
[GEN TEST] Failed to generate tests. Error: Object |
kevindiu
commented
Apr 11, 2023
github-actions
bot
added
area/agent/core
area/agent/sidecar
area/discoverer
area/gateway/filter
area/gateway/lb
area/internal
area/manager/index
area/tools/cli/loadtest
team/set
kevindiu
force-pushed
the
ci/fix-chatopts-gen-test-command
branch
from
618ed48 to
4a8f864
Compare
github-actions
bot
added
team/sre
github-actions
bot
added
size/S
and removed
area/gateway/filter
area/gateway/lb
area/agent/sidecar
area/agent/core
team/set
kevindiu
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2004 +/- ##
==========================================
+ Coverage 29.48% 30.32% +0.83%
==========================================
Files 365 356 -9
Lines 34436 32994 -1442
==========================================
- Hits 10153 10004 -149
+ Misses 23865 22585 -1280
+ Partials 418 405 -13 see 13 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
[GEN TEST] Failed to generate tests. Error: Object |
kevindiu
changed the title
Signed-off-by: kevindiu <[email protected]>
kevindiu
changed the title
kpango
approved these changes
Apr 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the incorrect error output of
/gen-testchatopts command.Also it fixes some steps execute on all PR and causing error output on PR.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: