Refactor replace errors wrap with join #2001

ykadowak · 2023-04-10T08:47:43Z

Description:

Replaced errors.Wrap with errors.Join. Made some modifications to several tests accordingly.

Related Issue:

Versions:

Go Version: 1.20.3
Docker Version: 20.10.8
Kubernetes Version: 1.22.0
NGT Version: 2.0.9

Checklist:

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer:

This will be done in another PR.

vald/internal/net/grpc/stream.go

Lines 75 to 78 in e2a72fe

    
           // FIXME: It should have been errors.Join here, but it remains errors.Wrap because the bench/agent/stream tests will fail. 
        
           // The reason is likely that when it's changed to errors.Join, status.ParseError cannot parse errors correctly, 
        
           // but this needs to be investigated further. 
        
           errs = errors.Wrap(err, errs.Error())

cloudflare-workers-and-pages · 2023-04-10T08:47:45Z

Deploying with Cloudflare Pages

Latest commit:	`e2a72fe`
Status:	✅ Deploy successful!
Preview URL:	https://85657b9b.vald.pages.dev
Branch Preview URL:	https://refactor-errors-wrap-replace.vald.pages.dev

View logs

CLAassistant · 2023-04-10T08:47:48Z

All committers have signed the CLA.

vdaas-ci · 2023-04-10T08:51:55Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - replace the PR body by changelog details
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase main
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

vdaas-ci · 2023-04-10T08:52:19Z

[GEN TEST] Failed to generate tests. Error: Object

vdaas-ci · 2023-04-10T08:56:23Z

[GEN TEST] Failed to generate tests. Error: Object

codecov · 2023-04-10T09:14:56Z

Codecov Report

Patch coverage: 21.05% and project coverage change: -0.03 ⚠️

Comparison is base (e86bd80) 29.40% compared to head (e2a72fe) 29.38%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2001      +/-   ##
==========================================
- Coverage   29.40%   29.38%   -0.03%     
==========================================
  Files         366      366              
  Lines       34527    34532       +5     
==========================================
- Hits        10153    10147       -6     
- Misses      23956    23967      +11     
  Partials      418      418

Impacted Files	Coverage Δ
hack/benchmark/internal/operation/operation.go	`0.00% <0.00%> (ø)`
internal/backoff/backoff.go	`72.22% <0.00%> (ø)`
internal/circuitbreaker/manager.go	`0.00% <0.00%> (ø)`
internal/client/v1/client/discoverer/discover.go	`0.00% <0.00%> (ø)`
internal/file/file.go	`12.00% <0.00%> (ø)`
internal/log/zap/zap.go	`84.42% <0.00%> (ø)`
internal/net/dialer.go	`77.40% <0.00%> (ø)`
internal/net/grpc/client.go	`0.00% <0.00%> (ø)`
internal/net/grpc/pool/pool.go	`0.00% <0.00%> (ø)`
internal/net/grpc/stream.go	`0.00% <0.00%> (ø)`
... and 26 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

vdaas-ci · 2023-04-10T09:15:40Z

[GEN TEST] Failed to generate tests. Error: Object

vdaas-ci · 2023-04-11T02:33:42Z

Profile Report

type	vald-agent-ngt	vald-lb-gateway	vald-discoverer	vald-manager-index
cpu
heap

other images

vdaas-ci · 2023-04-12T07:17:32Z

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

vdaas-ci · 2023-04-18T08:24:53Z

Profile Report

type	vald-agent-ngt	vald-lb-gateway	vald-discoverer	vald-manager-index
cpu
heap

other images

vankichi

LGTM! Thanks 😄
Welcome to Vald world 🎉

internal/net/grpc/stream.go

kpango

LGTM thanks

kpango · 2023-04-18T17:02:12Z

@all-contributors please add @ykadowak for code,test

allcontributors · 2023-04-18T17:02:22Z

@kpango

I've put up a pull request to add @ykadowak! 🎉

github-actions · 2023-04-19T00:22:14Z

[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/refactor%2Ferrors-wrap%2Freplace-errors-wrap-with-join/6af1ac6c2b0817b1a66ce464692c8738b7e44bfa

vdaas-ci · 2023-04-19T00:35:55Z

Profile Report

type	vald-agent-ngt	vald-lb-gateway	vald-discoverer	vald-manager-index
cpu
heap

other images

ykadowak changed the title ~~[WIPtemporal commit~~ [WIP] Refactor replace errors wrap with join Apr 10, 2023

ykadowak force-pushed the refactor/errors-wrap/replace-errors-wrap-with-join branch from b8d2af0 to a724759 Compare April 10, 2023 08:50

github-actions bot added the area/internal label Apr 10, 2023

github-actions bot added size/S type/refactoring labels Apr 10, 2023

github-actions bot added the priority/low label Apr 10, 2023

ykadowak added actions/e2e-deploy actions/e2e-chaos actions/e2e-profiling actions/e2e-max-dim labels Apr 11, 2023

ykadowak force-pushed the refactor/errors-wrap/replace-errors-wrap-with-join branch from a724759 to d0fc34e Compare April 12, 2023 07:12

github-actions bot added team/set SET team size/L labels Apr 12, 2023

github-actions bot added area/agent/core and removed size/S labels Apr 12, 2023

ykadowak added 5 commits April 12, 2023 18:00

replace for internal pkgs

e3554d8

fix want error message

2678dfa

fix test

a8b162f

fix test for pkg

b20b950

replace Wrap with Join for pkg packages

1e1a6f4

ykadowak force-pushed the refactor/errors-wrap/replace-errors-wrap-with-join branch from ab6afae to 1e1a6f4 Compare April 12, 2023 09:07

vankichi self-requested a review April 18, 2023 08:10

ykadowak added actions/e2e-deploy actions/e2e-chaos actions/e2e-profiling actions/e2e-max-dim and removed actions/e2e-deploy actions/e2e-chaos actions/e2e-profiling actions/e2e-max-dim labels Apr 18, 2023

vankichi approved these changes Apr 18, 2023

View reviewed changes

internal/net/grpc/stream.go Show resolved Hide resolved

kpango approved these changes Apr 18, 2023

View reviewed changes

allcontributors bot mentioned this pull request Apr 18, 2023

docs: add ykadowak as a contributor for code, and test #2009

Merged

ykadowak added actions/e2e-deploy actions/fossa actions/e2e-chaos actions/e2e-profiling actions/e2e-max-dim and removed actions/e2e-deploy actions/fossa actions/e2e-chaos actions/e2e-profiling actions/e2e-max-dim labels Apr 19, 2023

vankichi merged commit d7c6bd3 into main Apr 19, 2023

vankichi deleted the refactor/errors-wrap/replace-errors-wrap-with-join branch April 19, 2023 01:35

ykadowak mentioned this pull request Apr 24, 2023

[patch] release v1.7.5 #2013

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor replace errors wrap with join #2001

Refactor replace errors wrap with join #2001

ykadowak commented Apr 10, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Apr 10, 2023 •

edited

Loading

CLAassistant commented Apr 10, 2023 •

edited

Loading

vdaas-ci commented Apr 10, 2023

vdaas-ci commented Apr 10, 2023

vdaas-ci commented Apr 10, 2023

codecov bot commented Apr 10, 2023 •

edited

Loading

vdaas-ci commented Apr 10, 2023

vdaas-ci commented Apr 11, 2023

vdaas-ci commented Apr 12, 2023

vdaas-ci commented Apr 18, 2023

vankichi left a comment

kpango left a comment

kpango commented Apr 18, 2023

allcontributors bot commented Apr 18, 2023

github-actions bot commented Apr 19, 2023

vdaas-ci commented Apr 19, 2023

	// FIXME: It should have been errors.Join here, but it remains errors.Wrap because the bench/agent/stream tests will fail.
	// The reason is likely that when it's changed to errors.Join, status.ParseError cannot parse errors correctly,
	// but this needs to be investigated further.
	errs = errors.Wrap(err, errs.Error())

Refactor replace errors wrap with join #2001

Refactor replace errors wrap with join #2001

Conversation

ykadowak commented Apr 10, 2023 • edited Loading

Description:

Related Issue:

Versions:

Checklist:

Special notes for your reviewer:

cloudflare-workers-and-pages bot commented Apr 10, 2023 • edited Loading

Deploying with Cloudflare Pages

CLAassistant commented Apr 10, 2023 • edited Loading

vdaas-ci commented Apr 10, 2023

vdaas-ci commented Apr 10, 2023

vdaas-ci commented Apr 10, 2023

codecov bot commented Apr 10, 2023 • edited Loading

Codecov Report

vdaas-ci commented Apr 10, 2023

vdaas-ci commented Apr 11, 2023

Profile Report

vdaas-ci commented Apr 12, 2023

vdaas-ci commented Apr 18, 2023

Profile Report

vankichi left a comment

Choose a reason for hiding this comment

kpango left a comment

Choose a reason for hiding this comment

kpango commented Apr 18, 2023

allcontributors bot commented Apr 18, 2023

github-actions bot commented Apr 19, 2023

vdaas-ci commented Apr 19, 2023

Profile Report

ykadowak commented Apr 10, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Apr 10, 2023 •

edited

Loading

CLAassistant commented Apr 10, 2023 •

edited

Loading

codecov bot commented Apr 10, 2023 •

edited

Loading