-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix: fix range concurrency branch rule #1986
Bug fix: fix range concurrency branch rule #1986
Conversation
Signed-off-by: vankichi <[email protected]>
Deploying with Cloudflare Pages
|
[CHATOPS:HELP] ChatOps commands.
|
Profile Report
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1986 +/- ##
==========================================
- Coverage 29.61% 29.59% -0.02%
==========================================
Files 365 365
Lines 34242 34245 +3
==========================================
- Hits 10140 10136 -4
- Misses 23683 23689 +6
- Partials 419 420 +1
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Description:
I have fixed the concurrency branch rule at the
internal/net/grpc/client.go
.Thanks to #1953 , the backoff problem is resolved.
However, the concurrency branch rule affects the lb service.
Ref: https://github.com/vdaas/vald/blob/main/pkg/gateway/lb/service/gateway.go#L72-L86
So, I have fixed it with @hlts2 and @kpango .
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: