Implement index with timestamp #1984

datelier · 2023-03-27T06:00:40Z

Description:

Add "index with timestamp" feature.

Related Issue:

Versions:

Go Version: 1.20.2
Docker Version: 20.10.8
Kubernetes Version: 1.22.0
NGT Version: 2.0.9

Checklist:

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer:

cloudflare-workers-and-pages · 2023-03-27T06:00:58Z

Deploying with Cloudflare Pages

Latest commit:	`3c2db9c`
Status:	✅ Deploy successful!
Preview URL:	https://13a8fe07.vald.pages.dev
Branch Preview URL:	https://feature-kvs-index-with-times.vald.pages.dev

View logs

vdaas-ci · 2023-03-27T06:01:01Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - replace the PR body by changelog details
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase main
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

github-actions · 2023-03-27T06:27:26Z

pkg/agent/core/ngt/service/ngt.go

+			n.fmap[k] = int64(id)
+		}
+	}
+	for k, _:= range mt {


🚫 [golangci] _{reported by reviewdog 🐶}
File is not gofumpt-ed (gofumpt)

codecov · 2023-03-27T06:38:16Z

Codecov Report

Patch coverage: 24.87% and project coverage change: -0.11 ⚠️

Comparison is base (88a417c) 29.49% compared to head (3c2db9c) 29.38%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1984      +/-   ##
==========================================
- Coverage   29.49%   29.38%   -0.11%     
==========================================
  Files         365      365              
  Lines       34436    34517      +81     
==========================================
- Hits        10157    10143      -14     
- Misses      23862    23955      +93     
- Partials      417      419       +2

Impacted Files	Coverage Δ
pkg/agent/core/ngt/service/ngt.go	`18.94% <5.04%> (-1.54%)`	⬇️
pkg/agent/core/ngt/service/kvs/ou.go	`36.11% <33.33%> (ø)`
pkg/agent/core/ngt/service/vqueue/queue.go	`72.78% <50.00%> (ø)`
pkg/agent/core/ngt/service/kvs/uo.go	`56.42% <63.33%> (ø)`
pkg/agent/core/ngt/service/kvs/kvs.go	`82.19% <100.00%> (ø)`

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

kpango

LGTM

github-actions · 2023-04-05T02:37:53Z

pkg/agent/core/ngt/service/kvs/ou.go

@@ -32,18 +32,23 @@ type readOnlyOu struct {
 }

 // skipcq: GSC-G103
-var expungedOu = unsafe.Pointer(new(string))
+var expungedOu = unsafe.Pointer(new(ValueStructOu))


🚫 [golangci] _{reported by reviewdog 🐶}
G103: Use of unsafe calls should be audited (gosec)

github-actions · 2023-04-05T02:37:53Z

pkg/agent/core/ngt/service/kvs/kvs_test.go

-			var oldVal uint32 = 10000
+			var (
+				oldVal uint32 = 10000
+				oldTs  int64  = 20000


🚫 [golangci] _{reported by reviewdog 🐶}
ST1003: var oldTs should be oldTS (stylecheck)

pkg/agent/core/ngt/service/kvs/kvs_test.go

kpango

LGTM

hlts2

LGTM!

datelier · 2023-04-10T06:17:03Z

/rebase

vdaas-ci · 2023-04-10T06:17:38Z

[REBASE] Rebase triggered by datelier for branch: feature/kvs/index-with-timestamp

vdaas-ci · 2023-04-10T06:17:45Z

[REBASE] Failed to rebase.

hlts2

LGTM

vdaas-ci · 2023-04-12T04:41:27Z

[REBASE] Failed to rebase.

vdaas-ci · 2023-04-12T04:53:17Z

Profile Report

type	vald-agent-ngt	vald-lb-gateway	vald-discoverer	vald-manager-index
cpu
heap

other images

hlts2

LGTM

vdaas-ci · 2023-04-12T06:36:20Z

Profile Report

type	vald-agent-ngt	vald-lb-gateway	vald-discoverer	vald-manager-index
cpu
heap

other images

kpango

LGTM

datelier requested review from kpango and hlts2 March 27, 2023 06:00

github-actions bot added area/agent/core size/L type/feature New feature priority/medium labels Mar 27, 2023

github-actions bot reviewed Mar 27, 2023

View reviewed changes

kpango previously approved these changes Apr 3, 2023

View reviewed changes

datelier dismissed kpango’s stale review via 208c749 April 5, 2023 01:48

github-actions bot added team/set SET team size/XL and removed size/L labels Apr 5, 2023

datelier force-pushed the feature/kvs/index-with-timestamp branch from 181bc27 to 0d1e13c Compare April 5, 2023 01:59

github-actions bot reviewed Apr 5, 2023

View reviewed changes

pkg/agent/core/ngt/service/kvs/kvs_test.go Outdated Show resolved Hide resolved

kpango previously approved these changes Apr 5, 2023

View reviewed changes

hlts2 previously approved these changes Apr 6, 2023

View reviewed changes

datelier dismissed stale reviews from hlts2 and kpango via 3568a14 April 10, 2023 06:21

datelier force-pushed the feature/kvs/index-with-timestamp branch from 53659cb to 3568a14 Compare April 10, 2023 06:21

hlts2 previously approved these changes Apr 10, 2023

View reviewed changes

kpango previously approved these changes Apr 10, 2023

View reviewed changes

kpango added actions/e2e-deploy actions/fossa labels Apr 10, 2023

datelier force-pushed the feature/kvs/index-with-timestamp branch from 1c7f02a to 7ff7ccd Compare April 12, 2023 04:42

datelier added actions/e2e-deploy actions/e2e-chaos actions/e2e-profiling actions/e2e-max-dim and removed actions/e2e-deploy actions/e2e-chaos actions/e2e-profiling actions/e2e-max-dim labels Apr 12, 2023

kpango previously approved these changes Apr 12, 2023

View reviewed changes

hlts2 previously approved these changes Apr 12, 2023

View reviewed changes

add index with timestamp

3c2db9c

datelier dismissed stale reviews from hlts2 and kpango via 3c2db9c April 12, 2023 06:23

datelier force-pushed the feature/kvs/index-with-timestamp branch from 7ff7ccd to 3c2db9c Compare April 12, 2023 06:23

datelier added actions/e2e-deploy actions/e2e-chaos actions/e2e-profiling actions/e2e-max-dim and removed actions/e2e-deploy actions/e2e-chaos actions/e2e-profiling actions/e2e-max-dim labels Apr 12, 2023

kpango approved these changes Apr 12, 2023

View reviewed changes

kpango merged commit 6a1fd87 into main Apr 12, 2023

kpango deleted the feature/kvs/index-with-timestamp branch April 12, 2023 07:10

ykadowak mentioned this pull request Apr 24, 2023

[patch] release v1.7.5 #2013

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement index with timestamp #1984

Implement index with timestamp #1984

datelier commented Mar 27, 2023

cloudflare-workers-and-pages bot commented Mar 27, 2023 •

edited

Loading

vdaas-ci commented Mar 27, 2023

github-actions bot Mar 27, 2023

codecov bot commented Mar 27, 2023 •

edited

Loading

kpango left a comment

github-actions bot Apr 5, 2023

github-actions bot Apr 5, 2023

kpango left a comment

hlts2 left a comment

datelier commented Apr 10, 2023

vdaas-ci commented Apr 10, 2023

vdaas-ci commented Apr 10, 2023

hlts2 left a comment

vdaas-ci commented Apr 12, 2023

vdaas-ci commented Apr 12, 2023

hlts2 left a comment

vdaas-ci commented Apr 12, 2023

kpango left a comment

Implement index with timestamp #1984

Implement index with timestamp #1984

Conversation

datelier commented Mar 27, 2023

Description:

Related Issue:

Versions:

Checklist:

Special notes for your reviewer:

cloudflare-workers-and-pages bot commented Mar 27, 2023 • edited Loading

Deploying with Cloudflare Pages

vdaas-ci commented Mar 27, 2023

github-actions bot Mar 27, 2023

Choose a reason for hiding this comment

codecov bot commented Mar 27, 2023 • edited Loading

Codecov Report

kpango left a comment

Choose a reason for hiding this comment

github-actions bot Apr 5, 2023

Choose a reason for hiding this comment

github-actions bot Apr 5, 2023

Choose a reason for hiding this comment

kpango left a comment

Choose a reason for hiding this comment

hlts2 left a comment

Choose a reason for hiding this comment

datelier commented Apr 10, 2023

vdaas-ci commented Apr 10, 2023

vdaas-ci commented Apr 10, 2023

hlts2 left a comment

Choose a reason for hiding this comment

vdaas-ci commented Apr 12, 2023

vdaas-ci commented Apr 12, 2023

Profile Report

hlts2 left a comment

Choose a reason for hiding this comment

vdaas-ci commented Apr 12, 2023

Profile Report

kpango left a comment

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Mar 27, 2023 •

edited

Loading

codecov bot commented Mar 27, 2023 •

edited

Loading