add new agents helm template base. #1975

kpango · 2023-03-13T06:05:12Z

Description:

WIP

Related Issue:

Versions:

Go Version: 1.20.2
Docker Version: 20.10.8
Kubernetes Version: 1.22.0
NGT Version: 2.0.9

Checklist:

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer:

vdaas-ci · 2023-03-13T06:06:01Z

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

vdaas-ci · 2023-03-13T06:06:40Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - replace the PR body by changelog details
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase main
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

cloudflare-workers-and-pages · 2023-03-13T06:12:05Z

Deploying with Cloudflare Pages

Latest commit:	`afd2469`
Status:	✅ Deploy successful!
Preview URL:	https://a8688e42.vald.pages.dev
Branch Preview URL:	https://feature-agent-new-agents-hel.vald.pages.dev

View logs

internal/observability/metrics/manager/index/index.go

-			isIndexing,
-		},
-		func(ctx context.Context) {
+	_, err = m.RegisterCallback(


sonatype-lift · 2023-03-13T06:27:42Z

internal/net/grpc/admin/admin.go

+	"google.golang.org/grpc/admin"
+)
+
+var Register = admin.Register


gochecknoglobals: Register is a global variable

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

github-actions · 2023-03-13T06:41:46Z

internal/observability/metrics/manager/index/index.go

-			isIndexing.Observe(ctx, int64(indexing))
+			o.ObserveInt64(uuidCount, int64(im.indexer.NumberOfUUIDs()))
+			o.ObserveInt64(uncommittedUUIDCount, int64(im.indexer.NumberOfUncommittedUUIDs()))
+			o.ObserveInt64(isIndexing, int64(indexing))


🚫 [golangci] _{reported by reviewdog 🐶}
unnecessary conversion (unconvert)

github-actions · 2023-03-13T06:41:46Z

internal/net/grpc/admin/admin.go

+	"google.golang.org/grpc/admin"
+)
+
+var Register = admin.Register


🚫 [golangci] _{reported by reviewdog 🐶}
Register is a global variable (gochecknoglobals)

github-actions · 2023-03-13T06:41:46Z

internal/observability/metrics/manager/index/index.go

-			isIndexing,
-		},
-		func(ctx context.Context) {
+	_, err = m.RegisterCallback(


🚫 [golangci] _{reported by reviewdog 🐶}
ineffectual assignment to err (ineffassign)

codecov · 2023-03-13T06:46:02Z

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (ceb04ea) 30.02% compared to head (bd8c3df) 30.73%.
Report is 3 commits behind head on main.

❗ Current head bd8c3df differs from pull request most recent head afd2469. Consider uploading reports for the commit afd2469 to get more accurate results

Files	Patch %	Lines
internal/config/faiss.go	0.00%	18 Missing ⚠️
internal/errors/faiss.go	0.00%	6 Missing ⚠️
internal/config/server.go	0.00%	4 Missing and 1 partial ⚠️
...ernal/net/grpc/interceptor/server/metric/metric.go	0.00%	5 Missing ⚠️
...l/net/grpc/interceptor/server/logging/accesslog.go	0.00%	4 Missing ⚠️
internal/observability/exporter/otlp/otlp.go	0.00%	3 Missing ⚠️
internal/info/info.go	33.33%	1 Missing and 1 partial ⚠️
hack/license/gen/main.go	0.00%	1 Missing ⚠️
internal/client/v1/client/agent/core/client.go	0.00%	1 Missing ⚠️
internal/net/grpc/errdetails/errdetails.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1975      +/-   ##
==========================================
+ Coverage   30.02%   30.73%   +0.70%     
==========================================
  Files         371      359      -12     
  Lines       36089    34176    -1913     
==========================================
- Hits        10837    10505     -332     
+ Misses      24738    23187    -1551     
+ Partials      514      484      -30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sonatype-lift · 2023-04-04T04:37:11Z

internal/observability/metrics/runtime/goroutine/goroutine.go

 	}, nil
 }

-func (*goroutine) Register(m metrics.Meter) error {
-	conter, err := m.AsyncInt64().Gauge(
+func (*goroutine) Register(m metrics.Meter) (err error) {


nonamedreturns: named return "err" with type "error" found

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-04-04T04:37:13Z

internal/observability/metrics/mem/index/index.go

-		},
-		func(ctx context.Context) {
+	_, err = m.RegisterCallback(
+		func(_ context.Context, o api.Observer) error {


varnamelen: parameter name 'o' is too short for the scope of its usage

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-06-29T05:50:06Z

pkg/agent/core/faiss/config/config.go

+	}
+
+	if cfg != nil {
+		cfg.Bind()


typecheck: cfg.Bind undefined (type *Data has no field or method Bind)

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-04T05:06:34Z

internal/observability/metrics/agent/sidecar/sidecar.go

@@ -141,15 +134,19 @@ func (sm *sidecarMetrics) Register(m metrics.Meter) error {
 				attribute.String(sm.filenameKey, sm.info.Filename),
 			}

+			o.ObserveInt64(uploadTotal, 1, attrs...)


typecheck: cannot use attrs (variable of type []"go.opentelemetry.io/otel/attribute".KeyValue) as []"go.opentelemetry.io/otel/metric".ObserveOption value in argument to o.ObserveInt64

❗❗ 2 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

internal/observability/metrics/info/info.go 116

internal/observability/metrics/version/version.go 109

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-04T05:06:36Z

internal/observability/metrics/metrics.go


 var (
+	// WithUnit returns an metric.WithUnit option.
+	WithUnit = metric.WithUnit


gochecknoglobals: WithUnit is a global variable

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-04T05:06:37Z

internal/observability/metrics/metrics.go

+	// WithUnit returns an metric.WithUnit option.
+	WithUnit = metric.WithUnit
+	// WithDescription returns an metric.WithDescription option.
+	WithDescription = metric.WithDescription


gochecknoglobals: WithDescription is a global variable

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-04T07:05:08Z

internal/observability/attribute/attribute.go


 type (
 	KeyValue = attribute.KeyValue
 	Key      = attribute.Key
 )

+var ToMeasurementOption = api.WithAttributes


gochecknoglobals: ToMeasurementOption is a global variable

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-04T10:11:04Z

cmd/agent/core/faiss/main_test.go

+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package faiss


typecheck: package faiss; expected main

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-04T10:11:06Z

internal/observability/metrics/metrics_test.go

+// 	}
+// 	type test struct {
+// 		name       string
+// 		want       want


dupword: Duplicate words (want) found

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-04T10:37:46Z

internal/observability/metrics/grpc/grpc.go

+func (*grpcServerMetrics) View() ([]metrics.View, error) {
+	return []metrics.View{
+		view.NewView(
+			view.Instrument{


exhaustruct: Kind, Unit, Scope are missing in Instrument

❗❗ 6 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

internal/observability/metrics/grpc/grpc.go 43

internal/observability/metrics/grpc/grpc.go 44

internal/observability/metrics/grpc/grpc.go 50

internal/observability/metrics/grpc/grpc.go 54

internal/observability/metrics/mem/index/index.go 80

internal/observability/metrics/mem/index/index.go 84

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

sonatype-lift · 2023-07-04T10:37:49Z

internal/observability/metrics/runtime/cgo/cgo.go

+			view.Stream{
+				Aggregation: aggregation.LastValue{},
+			},
+		),
 	}, nil
 }

 func (*cgo) Register(m metrics.Meter) error {


varnamelen: parameter name 'm' is too short for the scope of its usage

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

This commit fixes the style issues introduced in 0c7085c according to the output from Gofumpt and Prettier. Details: #1975

github-actions bot added area/agent/core area/discoverer area/gateway/filter area/gateway/lb area/helm area/internal area/makefile area/manager/index team/set SET team team/sre SRE team type/ci size/XXL type/feature New feature labels Mar 13, 2023

github-actions bot added the priority/medium label Mar 13, 2023

kpango force-pushed the feature/agent/new-agents-helm-template-base branch from 48f1321 to cb51ed1 Compare March 13, 2023 06:12

github-advanced-security bot found potential problems Mar 13, 2023

View reviewed changes

internal/observability/metrics/manager/index/index.go Outdated

isIndexing,

},

func(ctx context.Context) {

_, err = m.RegisterCallback(

Check warning

Code scanning / CodeQL

Useless assignment to local variable

This definition of err is never used.

sonatype-lift bot reviewed Mar 13, 2023

View reviewed changes

github-actions bot reviewed Mar 13, 2023

View reviewed changes

sonatype-lift bot reviewed Apr 4, 2023

View reviewed changes

kpango force-pushed the feature/agent/new-agents-helm-template-base branch 2 times, most recently from 34edd31 to 68c329e Compare April 10, 2023 16:59

kpango force-pushed the feature/agent/new-agents-helm-template-base branch 2 times, most recently from 9bd1e34 to 4892382 Compare April 20, 2023 05:44

kpango force-pushed the main branch from fd9f8c1 to 497c7dd Compare June 15, 2023 05:52

sonatype-lift bot reviewed Jun 29, 2023

View reviewed changes

kpango force-pushed the feature/agent/new-agents-helm-template-base branch from 8842428 to 81bbbe2 Compare July 4, 2023 04:47

sonatype-lift bot reviewed Jul 4, 2023

View reviewed changes

kpango force-pushed the feature/agent/new-agents-helm-template-base branch 4 times, most recently from 352631c to dde6c6a Compare July 4, 2023 06:51

sonatype-lift bot reviewed Jul 4, 2023

View reviewed changes

kpango force-pushed the feature/agent/new-agents-helm-template-base branch 2 times, most recently from bd8c3df to b2c5574 Compare July 4, 2023 09:53

sonatype-lift bot reviewed Jul 4, 2023

View reviewed changes

kpango force-pushed the feature/agent/new-agents-helm-template-base branch from b2c5574 to ee54445 Compare July 4, 2023 10:23

sonatype-lift bot reviewed Jul 4, 2023

View reviewed changes

kpango force-pushed the feature/agent/new-agents-helm-template-base branch 3 times, most recently from b11d50c to f0e27ea Compare July 16, 2023 03:01

github-actions bot added the area/tools/cli/loadtest label Jul 16, 2023

kpango force-pushed the feature/agent/new-agents-helm-template-base branch from f0e27ea to 51976a1 Compare July 16, 2023 03:04

kpango force-pushed the feature/agent/new-agents-helm-template-base branch from 51976a1 to 0c7085c Compare December 21, 2023 07:29

deepsource-autofix bot added a commit that referenced this pull request Dec 21, 2023

style: format code with Gofumpt and Prettier

7ca393e

This commit fixes the style issues introduced in 0c7085c according to the output from Gofumpt and Prettier. Details: #1975

kpango force-pushed the feature/agent/new-agents-helm-template-base branch 2 times, most recently from 2047b87 to afd2469 Compare December 21, 2023 08:27

kpango closed this Dec 28, 2023

kpango force-pushed the feature/agent/new-agents-helm-template-base branch from afd2469 to dd2c92b Compare December 28, 2023 05:35

kpango deleted the feature/agent/new-agents-helm-template-base branch December 28, 2023 05:35

kpango restored the feature/agent/new-agents-helm-template-base branch December 28, 2023 05:35

kpango deleted the feature/agent/new-agents-helm-template-base branch December 28, 2023 05:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add new agents helm template base. #1975

add new agents helm template base. #1975

kpango commented Mar 13, 2023

vdaas-ci commented Mar 13, 2023

vdaas-ci commented Mar 13, 2023

cloudflare-workers-and-pages bot commented Mar 13, 2023 •

edited

Loading

sonatype-lift bot Mar 13, 2023

github-actions bot Mar 13, 2023

github-actions bot Mar 13, 2023

github-actions bot Mar 13, 2023

codecov bot commented Mar 13, 2023 •

edited

Loading

sonatype-lift bot Apr 4, 2023

sonatype-lift bot Apr 4, 2023

sonatype-lift bot Jun 29, 2023

sonatype-lift bot Jul 4, 2023

sonatype-lift bot Jul 4, 2023

sonatype-lift bot Jul 4, 2023

sonatype-lift bot Jul 4, 2023

sonatype-lift bot Jul 4, 2023

sonatype-lift bot Jul 4, 2023

sonatype-lift bot Jul 4, 2023

sonatype-lift bot Jul 4, 2023

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

File Path	Line Number
internal/observability/metrics/info/info.go	116
internal/observability/metrics/version/version.go	109

add new agents helm template base. #1975

add new agents helm template base. #1975

Conversation

kpango commented Mar 13, 2023

Description:

Related Issue:

Versions:

Checklist:

Special notes for your reviewer:

vdaas-ci commented Mar 13, 2023

vdaas-ci commented Mar 13, 2023

cloudflare-workers-and-pages bot commented Mar 13, 2023 • edited Loading

Deploying with Cloudflare Pages

sonatype-lift bot Mar 13, 2023

Choose a reason for hiding this comment

github-actions bot Mar 13, 2023

Choose a reason for hiding this comment

github-actions bot Mar 13, 2023

Choose a reason for hiding this comment

github-actions bot Mar 13, 2023

Choose a reason for hiding this comment

codecov bot commented Mar 13, 2023 • edited Loading

Codecov Report

sonatype-lift bot Apr 4, 2023

Choose a reason for hiding this comment

sonatype-lift bot Apr 4, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jun 29, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 4, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 4, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 4, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 4, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 4, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 4, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 4, 2023

Choose a reason for hiding this comment

sonatype-lift bot Jul 4, 2023

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Mar 13, 2023 •

edited

Loading

codecov bot commented Mar 13, 2023 •

edited

Loading