Refactor conv.go

[kpango]

Description:

SSIA

Related Issue:

Versions:

• Go Version: 1.20.2
• Docker Version: 20.10.8
• Kubernetes Version: 1.22.0
• NGT Version: 2.0.9

Checklist:

• I have read the CONTRIBUTING document and completed our CLA agreement.
• I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer:

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	2119059
Status:	⚡️  Build in progress...

View logs

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - replace the PR body by changelog details
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase main
• 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

[codecov]

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.01 🎉

Comparison is base (d9b0176) 29.67% compared to head (eccba1b) 29.69%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1968      +/-   ##
==========================================
+ Coverage   29.67%   29.69%   +0.01%     
==========================================
  Files         364      364              
  Lines       34171    34156      -15     
==========================================
+ Hits        10139    10141       +2     
+ Misses      23617    23601      -16     
+ Partials      415      414       -1     

Impacted Files	Coverage Δ
hack/helm/schema/crd/main.go	0.00% <0.00%> (ø)
hack/helm/schema/gen/main.go	0.00% <0.00%> (ø)
...b/storage/blob/cloudstorage/urlopener/urlopener.go	0.00% <0.00%> (ø)
internal/runner/runner.go	53.37% <0.00%> (ø)
internal/conv/conv.go	86.95% <90.00%> (+15.90%)	⬆️
internal/config/config.go	91.07% <100.00%> (ø)
internal/safety/safety.go	92.85% <100.00%> (ø)
internal/tls/tls.go	79.03% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[github-actions]

[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/refactor%2Finternal-conv%2Fuse-go-standard-libs/cd9e495a1075a16da013f996c4a95068a523a2d7

[vdaas-ci]

Profile Report

type	vald-agent-ngt	vald-lb-gateway	vald-discoverer	vald-manager-index
cpu
heap

other images

[vdaas-ci]

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

[github-actions]

[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/refactor%2Finternal-conv%2Fuse-go-standard-libs/ea305b6e6c55cc40708a9cdd26b92660c71529ea

[vdaas-ci]

Profile Report

type	vald-agent-ngt	vald-lb-gateway	vald-discoverer	vald-manager-index
cpu
heap

other images

[vankichi]

LGTM