impl: status handle and update crd logic for continuous benchmark tool

[vankichi]

Description:

I have implemented the status handle for each CRD according to the jobs' status and the updating reconciling logic when the scenario is updated.

It has 3 types of reconcile logic:

1. benchmarkScenarioReconcile
   • handle benchmark scenario resource (BSR) reconcile
   • It creates the benchmark job resource (BJR) with ownerReference when applying a new BSR.
   • It deletes the old BJR and creates a new one when updating BSR.
   • It stores BSR and its BJR name and status to the atomic.Pointer

     type scenario struct {
         Crd            *v1.ValdBenchmarkScenario
         BenchJobStatus map[string]v1.BenchmarkJobStatus
     }

2. benchmarkJobReconcile
   • handle BJR reconcile
   • It creates the job with ownerReference when applying a new BJR by benchmarkScenarioReconcile
     • It uses jobTemplate to create job resources.
   • It deletes the old BJR and creates a new one when updating the BJR directory.
   • It stores BJR to the atomic.Pointer
3. jobReconcile
   • handle job reconcile
   • It checks the reconciled job status and updates BJR status according to its status.

And more, the operator checks the job status and updates the scenario status continuously.

• checks whether atomic.Pointer of the scenario
• checks whether the stored scenario should be updated its status to completed.
• gets the job and determines whether BJR should be updated its status to completed.

Related Issue:

Versions:

• Go Version: 1.20
• Docker Version: 20.10.8
• Kubernetes Version: 1.22.0
• NGT Version: 2.0.9

Checklist:

• I have read the CONTRIBUTING document and completed our CLA agreement.
• I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer:

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	50bda74
Status:	✅  Deploy successful!
Preview URL:	https://e0918440.vald.pages.dev
Branch Preview URL:	https://feature-internal-pkg-status-.vald.pages.dev

View logs

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - replace the PR body by changelog details
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase main
• 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

[vdaas-ci]

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (3b6ba49) 29.64% compared to head (7be3a30) 29.65%.

❗ Current head 7be3a30 differs from pull request most recent head 50bda74. Consider uploading reports for the commit 50bda74 to get more accurate results

Additional details and impacted files

@@                      Coverage Diff                      @@
##           feature/continuous-benchmark    #1955   +/-   ##
=============================================================
  Coverage                         29.64%   29.65%           
=============================================================
  Files                               366      367    +1     
  Lines                             34193    34205   +12     
=============================================================
+ Hits                              10136    10142    +6     
- Misses                            23640    23648    +8     
+ Partials                            417      415    -2     

Impacted Files	Coverage Δ
internal/config/benchmark.go	0.00% <ø> (ø)
internal/errors/benchmark.go	0.00% <0.00%> (ø)
internal/k8s/reconciler.go	0.00% <ø> (ø)
pkg/tools/benchmark/job/config/config.go	9.09% <0.00%> (-1.12%)	⬇️
internal/net/http/middleware/timeout.go	91.11% <0.00%> (-2.23%)	⬇️
internal/errgroup/group.go	92.92% <0.00%> (-2.03%)	⬇️
internal/worker/queue.go	98.68% <0.00%> (-1.32%)	⬇️
internal/worker/worker.go	82.30% <0.00%> (ø)
pkg/agent/core/ngt/service/vqueue/indexmap.go	77.00% <0.00%> (+5.34%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[github-actions]

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

pkg/tools/benchmark/job/service/job.go|107 col 30| named return "err" with type "error" found (nonamedreturns)
pkg/tools/benchmark/operator/service/operator.go|366 col 1| named return "jobNames" with type "[]string" found (nonamedreturns)
pkg/tools/benchmark/job/service/job.go|108 col 4| variable name 'dt' is too short for the scope of its usage (varnamelen)
pkg/tools/benchmark/job/service/option.go|197 col 14| parameter name 'j' is too short for the scope of its usage (varnamelen)
internal/k8s/vald/benchmark/job/job_template.go|39 col 2| variable name 'j' is too short for the scope of its usage (varnamelen)
pkg/tools/benchmark/operator/service/operator.go|170 col 2| variable name 'cj' is too short for the scope of its usage (varnamelen)
pkg/tools/benchmark/operator/service/operator.go|537 col 5| variable name 'sc' is too short for the scope of its usage (varnamelen)
pkg/tools/benchmark/operator/service/operator.go|437 col 7| variable name 'r' is too short for the scope of its usage (varnamelen)
pkg/tools/benchmark/operator/service/operator.go|418 col 6| variable name 'r' is too short for the scope of its usage (varnamelen)
pkg/tools/benchmark/operator/service/operator.go|228 col 6| variable name 'k' is too short for the scope of its usage (varnamelen)
pkg/tools/benchmark/operator/service/operator.go|289 col 6| variable name 'k' is too short for the scope of its usage (varnamelen)
pkg/tools/benchmark/operator/service/operator.go|178 col 7| variable name 'jn' is too short for the scope of its usage (varnamelen)
pkg/tools/benchmark/operator/service/operator.go|179 col 7| variable name 'j' is too short for the scope of its usage (varnamelen)
pkg/tools/benchmark/operator/service/operator.go|457 col 2| variable name 'bj' is too short for the scope of its usage (varnamelen)
pkg/tools/benchmark/operator/service/operator.go|377 col 3| variable name 'bj' is too short for the scope of its usage (varnamelen)
pkg/tools/benchmark/operator/service/operator.go|530 col 3| variable name 'dt' is too short for the scope of its usage (varnamelen)
pkg/tools/benchmark/operator/service/operator.go|543 col 10| variable name 'k' is too short for the scope of its usage (varnamelen)
pkg/tools/benchmark/operator/service/operator.go|72 col 2| variable name 'o' is too short for the scope of its usage (varnamelen)
pkg/tools/benchmark/operator/service/operator.go|89 col 2| variable name 'bs' is too short for the scope of its usage (varnamelen)
pkg/tools/benchmark/operator/usecase/benchmarkd.go|59 col 2| variable name 'op' is too short for the scope of its usage (varnamelen)

[sonatype-lift]

typecheck: Pointer not declared by package atomic

❗❗ 2 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path	Line Number
pkg/tools/benchmark/operator/service/operator.go	57
pkg/tools/benchmark/operator/service/operator.go	58

Visit the Lift Web Console to find more details in your report.

---

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command	Usage
@sonatype-lift ignore	Leave out the above finding from this PR
@sonatype-lift ignoreall	Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool>	Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

---

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]