Happy New Year 2023 #1918

vankichi · 2022-12-31T15:11:31Z

Description:

Happy New Year 2023

Related Issue:

Versions:

Go Version: 1.19.4
Docker Version: 20.10.8
Kubernetes Version: 1.22.0
NGT Version: 2.0.8

Checklist:

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer:

Signed-off-by: vankichi <[email protected]>

vdaas-ci · 2022-12-31T15:11:50Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - replace the PR body by changelog details
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase main
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

kpango

Happy New year @vankichi
LGTM, Thank you for your really fast work.

codecov · 2022-12-31T15:24:39Z

Codecov Report

Base: 50.23% // Head: 30.03% // Decreases project coverage by -20.20% ⚠️

Coverage data is based on head (6cc9538) compared to base (97eed29).
Patch has no changes to coverable lines.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1918       +/-   ##
===========================================
- Coverage   50.23%   30.03%   -20.21%     
===========================================
  Files         231      365      +134     
  Lines       13464    33701    +20237     
===========================================
+ Hits         6764    10121     +3357     
- Misses       6499    23173    +16674     
- Partials      201      407      +206

Impacted Files	Coverage Δ
cmd/agent/core/ngt/main.go	`0.00% <ø> (ø)`
cmd/agent/sidecar/main.go	`0.00% <ø> (ø)`
cmd/discoverer/k8s/main.go	`0.00% <ø> (ø)`
cmd/gateway/filter/main.go	`0.00% <ø> (ø)`
cmd/gateway/lb/main.go	`0.00% <ø> (ø)`
cmd/manager/index/main.go	`0.00% <ø> (ø)`
cmd/tools/cli/loadtest/main.go	`0.00% <ø> (ø)`
cmd/tools/cli/vdctl/main.go	`0.00% <ø> (ø)`
internal/observability/metrics/info/info.go	`0.00% <0.00%> (-100.00%)`	⬇️
internal/errors/vald.go	`50.00% <0.00%> (-16.67%)`	⬇️
... and 258 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

sonatype-lift · 2022-12-31T15:26:36Z

internal/observability/exporter/exporter.go

@@ -1,4 +1,4 @@
-// Copyright (C) 2019-2022 vdaas.org vald team <[email protected]>
+// Copyright (C) 2019-2023 vdaas.org vald team <[email protected]>


💬 12 similar findings have been found in this PR

stylecheck: ST1000: package comment should be of the form "Package exporter ..."

🔎 Expand here to view all instances of this finding

File Path Line Number

internal/db/storage/blob/s3/sdk/s3/s3.go 1

internal/db/storage/blob/s3/sdk/s3/s3iface/s3iface.go 1

hack/gorules/rules.go 1

internal/conv/conv.go 1

internal/db/storage/blob/s3/sdk/s3/s3manager/s3manager.go 1

internal/errors/circuitbreaker.go 1

internal/errors/info.go 1

internal/errors/option.go 1

internal/log/mock/logger.go 1

internal/log/mock/retry.go 1

Showing 10 of 12 findings. Visit the Lift Web Console to see all.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

internal/db/storage/blob/cloudstorage/urlopener/urlopener.go|1 col 1| ST1000: package comment should be of the form "Package urlopener ..." (stylecheck)
internal/db/storage/blob/s3/reader/io/io.go|1 col 1| ST1000: package comment should be of the form "Package io ..." (stylecheck)
internal/db/storage/blob/s3/sdk/s3/s3manager/s3manager.go|1 col 1| ST1000: package comment should be of the form "Package s3manager ..." (stylecheck)
internal/db/storage/blob/s3/writer/writer_mock.go|1 col 1| ST1000: package comment should be of the form "Package writer ..." (stylecheck)
internal/errors/circuitbreaker.go|1 col 1| ST1000: package comment should be of the form "Package errors ..." (stylecheck)
internal/errors/info.go|1 col 1| ST1000: package comment should be of the form "Package errors ..." (stylecheck)

github-actions · 2022-12-31T15:42:48Z

internal/net/grpc/interceptor/client/trace/trace.go

@@ -1,4 +1,4 @@
-// Copyright (C) 2019-2022 vdaas.org vald team <[email protected]>
+// Copyright (C) 2019-2023 vdaas.org vald team <[email protected]>


🚫 [golangci] _{reported by reviewdog 🐶}
ST1000: package comment should be of the form "Package trace ..." (stylecheck)

github-actions · 2022-12-31T15:42:48Z

charts/vald/values.go

@@ -1,4 +1,4 @@
-// Copyright (C) 2019-2022 vdaas.org vald team <[email protected]>
+// Copyright (C) 2019-2023 vdaas.org vald team <[email protected]>


🚫 [golangci] _{reported by reviewdog 🐶}
ST1000: package comment should be of the form "Package vald ..." (stylecheck)

github-actions · 2022-12-31T15:42:48Z

internal/observability/exporter/exporter.go

@@ -1,4 +1,4 @@
-// Copyright (C) 2019-2022 vdaas.org vald team <[email protected]>
+// Copyright (C) 2019-2023 vdaas.org vald team <[email protected]>


🚫 [golangci] _{reported by reviewdog 🐶}
ST1000: package comment should be of the form "Package exporter ..." (stylecheck)

github-actions · 2022-12-31T15:42:49Z

internal/db/storage/blob/s3/sdk/s3/s3.go

@@ -1,4 +1,4 @@
-// Copyright (C) 2019-2022 vdaas.org vald team <[email protected]>
+// Copyright (C) 2019-2023 vdaas.org vald team <[email protected]>


🚫 [golangci] _{reported by reviewdog 🐶}
ST1000: package comment should be of the form "Package s3 ..." (stylecheck)

github-actions · 2022-12-31T15:42:49Z

internal/db/storage/blob/s3/sdk/s3/s3iface/s3iface.go

@@ -1,4 +1,4 @@
-// Copyright (C) 2019-2022 vdaas.org vald team <[email protected]>
+// Copyright (C) 2019-2023 vdaas.org vald team <[email protected]>


🚫 [golangci] _{reported by reviewdog 🐶}
ST1000: package comment should be of the form "Package s3iface ..." (stylecheck)

github-actions · 2022-12-31T15:42:53Z

internal/db/kvs/redis/redis_mock.go

@@ -1,4 +1,4 @@
-// Copyright (C) 2019-2022 vdaas.org vald team <[email protected]>
+// Copyright (C) 2019-2023 vdaas.org vald team <[email protected]>


🚫 [golangci] _{reported by reviewdog 🐶}
ST1000: package comment should be of the form "Package redis ..." (stylecheck)

github-actions · 2022-12-31T15:42:54Z

internal/db/nosql/cassandra/cassandra_mock.go

@@ -1,4 +1,4 @@
-// Copyright (C) 2019-2022 vdaas.org vald team <[email protected]>
+// Copyright (C) 2019-2023 vdaas.org vald team <[email protected]>


🚫 [golangci] _{reported by reviewdog 🐶}
ST1000: package comment should be of the form "Package cassandra ..." (stylecheck)

github-actions · 2022-12-31T15:42:54Z

internal/db/storage/blob/cloudstorage/cloudstorage.go

@@ -1,4 +1,4 @@
-// Copyright (C) 2019-2022 vdaas.org vald team <[email protected]>
+// Copyright (C) 2019-2023 vdaas.org vald team <[email protected]>


🚫 [golangci] _{reported by reviewdog 🐶}
ST1000: package comment should be of the form "Package cloudstorage ..." (stylecheck)

github-actions · 2022-12-31T15:42:54Z

internal/db/storage/blob/cloudstorage/option.go

@@ -1,4 +1,4 @@
-// Copyright (C) 2019-2022 vdaas.org vald team <[email protected]>
+// Copyright (C) 2019-2023 vdaas.org vald team <[email protected]>


🚫 [golangci] _{reported by reviewdog 🐶}
ST1000: package comment should be of the form "Package cloudstorage ..." (stylecheck)

github-actions · 2022-12-31T15:42:54Z

internal/db/storage/blob/cloudstorage/urlopener/option.go

@@ -1,4 +1,4 @@
-// Copyright (C) 2019-2022 vdaas.org vald team <[email protected]>
+// Copyright (C) 2019-2023 vdaas.org vald team <[email protected]>


🚫 [golangci] _{reported by reviewdog 🐶}
ST1000: package comment should be of the form "Package urlopener ..." (stylecheck)

hlts2

LGTM !!

🎉 Happy New Year 2023

6cc9538

Signed-off-by: vankichi <[email protected]>

github-actions bot added area/agent/core area/agent/sidecar area/discoverer area/gateway/filter area/gateway/lb area/helm area/internal area/makefile area/manager/index area/tools/cli/loadtest team/set SET team team/sre SRE team type/ci size/XXL priority/low labels Dec 31, 2022

vankichi requested review from hlts2, datelier, kpango and kevindiu December 31, 2022 15:13

kpango approved these changes Dec 31, 2022

View reviewed changes

sonatype-lift bot reviewed Dec 31, 2022

View reviewed changes

github-actions bot reviewed Dec 31, 2022

View reviewed changes

hlts2 approved these changes Jan 1, 2023

View reviewed changes

kpango merged commit b9447c8 into main Jan 1, 2023

kpango deleted the happy-new-year-2023 branch January 1, 2023 00:56

kpango mentioned this pull request Jan 19, 2023

[minor] Release v1.7.0 #1926

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Happy New Year 2023 #1918

Happy New Year 2023 #1918

vankichi commented Dec 31, 2022

vdaas-ci commented Dec 31, 2022

kpango left a comment

codecov bot commented Dec 31, 2022 •

edited

Loading

sonatype-lift bot Dec 31, 2022

github-actions bot left a comment

github-actions bot Dec 31, 2022

github-actions bot Dec 31, 2022

github-actions bot Dec 31, 2022

github-actions bot Dec 31, 2022

github-actions bot Dec 31, 2022

github-actions bot Dec 31, 2022

github-actions bot Dec 31, 2022

github-actions bot Dec 31, 2022

github-actions bot Dec 31, 2022

github-actions bot Dec 31, 2022

hlts2 left a comment

		@@ -1,4 +1,4 @@
		// Copyright (C) 2019-2022 vdaas.org vald team <[email protected]>
		// Copyright (C) 2019-2023 vdaas.org vald team <[email protected]>

File Path	Line Number
internal/db/storage/blob/s3/sdk/s3/s3.go	1
internal/db/storage/blob/s3/sdk/s3/s3iface/s3iface.go	1
hack/gorules/rules.go	1
internal/conv/conv.go	1
internal/db/storage/blob/s3/sdk/s3/s3manager/s3manager.go	1
internal/errors/circuitbreaker.go	1
internal/errors/info.go	1
internal/errors/option.go	1
internal/log/mock/logger.go	1
internal/log/mock/retry.go	1

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

Happy New Year 2023 #1918

Happy New Year 2023 #1918

Conversation

vankichi commented Dec 31, 2022

Description:

Related Issue:

Versions:

Checklist:

Special notes for your reviewer:

vdaas-ci commented Dec 31, 2022

kpango left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 31, 2022 • edited Loading

Codecov Report

sonatype-lift bot Dec 31, 2022

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 31, 2022

Choose a reason for hiding this comment

github-actions bot Dec 31, 2022

Choose a reason for hiding this comment

github-actions bot Dec 31, 2022

Choose a reason for hiding this comment

github-actions bot Dec 31, 2022

Choose a reason for hiding this comment

github-actions bot Dec 31, 2022

Choose a reason for hiding this comment

github-actions bot Dec 31, 2022

Choose a reason for hiding this comment

github-actions bot Dec 31, 2022

Choose a reason for hiding this comment

github-actions bot Dec 31, 2022

Choose a reason for hiding this comment

github-actions bot Dec 31, 2022

Choose a reason for hiding this comment

github-actions bot Dec 31, 2022

Choose a reason for hiding this comment

hlts2 left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 31, 2022 •

edited

Loading