Add flush api #1895

aknishid · 2022-12-15T06:14:07Z

Description:

Flush API to delete all vectors has been added.

Related Issue:

Versions:

Go Version: 1.19.4
Docker Version: 20.10.8
Kubernetes Version: 1.22.0
NGT Version: 1.14.8

Checklist:

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer:

CLAassistant · 2022-12-15T06:14:16Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ takuyaymd
✅ aknishid
✅ kpango
❌ takuyyam

takuyyam seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

codecov · 2022-12-16T05:22:37Z

Codecov Report

Patch coverage: 1.67% and project coverage change: -0.43 ⚠️

Comparison is base (6f5fb18) 31.09% compared to head (355ae00) 30.67%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1895      +/-   ##
==========================================
- Coverage   31.09%   30.67%   -0.43%     
==========================================
  Files         339      340       +1     
  Lines       32831    33295     +464     
==========================================
+ Hits        10210    10212       +2     
- Misses      22169    22615     +446     
- Partials      452      468      +16

Impacted Files	Coverage Δ
internal/client/v1/client/vald/vald.go	`0.00% <0.00%> (ø)`
internal/core/algorithm/ngt/ngt.go	`61.57% <0.00%> (-1.17%)`	⬇️
internal/errors/ngt.go	`70.00% <ø> (ø)`
internal/file/file.go	`11.56% <0.00%> (-1.14%)`	⬇️
pkg/agent/core/ngt/handler/grpc/flush.go	`0.00% <0.00%> (ø)`
pkg/agent/core/ngt/handler/grpc/insert.go	`60.61% <0.00%> (-7.18%)`	⬇️
pkg/agent/core/ngt/handler/grpc/linear_search.go	`0.00% <0.00%> (ø)`
pkg/agent/core/ngt/handler/grpc/remove.go	`22.66% <0.00%> (-3.21%)`	⬇️
pkg/agent/core/ngt/handler/grpc/search.go	`22.00% <0.00%> (-1.11%)`	⬇️
pkg/agent/core/ngt/handler/grpc/update.go	`27.61% <0.00%> (-2.63%)`	⬇️
... and 3 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

sonatype-lift · 2022-12-16T05:32:02Z

internal/file/file.go

+			return err
+		}
+		eg.Go(safety.RecoverFunc(func() (err error) {
+			_, err = os.Delete(childPath)


typecheck: Delete not declared by package os

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-12-16T05:52:43Z

internal/file/file.go

+			return err
+		}
+		eg.Go(safety.RecoverFunc(func() (err error) {
+			_, err = os.Remove(childPath)


typecheck: cannot assign 1 values to 2 variables

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-12-16T07:39:10Z

internal/errors/ngt.go

@@ -21,6 +21,9 @@ var (
 	// ErrCreateIndexingIsInProgress represents an error that the indexing is in progress but search request received


godot: Comment should end in a period

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

internal/errors/ngt.go

sonatype-lift · 2023-03-13T10:13:22Z

internal/errors/ngt.go

@@ -18,6 +18,91 @@
 package errors

 var (
+	// ErrCreateIndexingIsInProgress represents an error that the indexing is in progress but search request received
+	ErrCreateIndexingIsInProgress = New("create indexing is in progress")


typecheck: ErrCreateIndexingIsInProgress redeclared in this block

❗❗ 10 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

internal/errors/ngt.go 28

internal/errors/ngt.go 33

internal/errors/ngt.go 36

internal/errors/ngt.go 39

internal/errors/ngt.go 42

internal/errors/ngt.go 50

internal/errors/ngt.go 55

internal/errors/ngt.go 60

internal/errors/ngt.go 65

internal/errors/ngt.go 68

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-04-07T06:47:17Z

internal/errors/ngt.go

+	ErrUnsupportedDistanceType = New("unsupported DistanceType")
+
+	// ErrFailedToSetDistanceType represents a function to generate an error that the set of distance type failed.
+	ErrFailedToSetDistanceType = func(err error, distance string) error {


typecheck: ErrFailedToSetDistanceType redeclared in this block

❗❗ 9 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

internal/errors/ngt.go 76

internal/errors/ngt.go 81

internal/errors/ngt.go 86

internal/errors/ngt.go 91

internal/errors/ngt.go 96

internal/errors/ngt.go 101

internal/errors/ngt.go 104

internal/file/file.go 22

internal/file/file.go 505

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

kpango

LGTM

kpango

LGTM

aknishid · 2023-12-14T08:34:40Z

I've opened a new PR (#2273), so I will be closing this one.

sonatype-lift bot reviewed Dec 16, 2022

View reviewed changes

kpango added the ci/approved label Dec 16, 2022

sonatype-lift bot reviewed Dec 16, 2022

View reviewed changes

internal/errors/ngt.go Outdated Show resolved Hide resolved

kpango added ci/approved and removed ci/approved labels Dec 16, 2022

kpango force-pushed the main branch 2 times, most recently from 9b3087a to 4a659f2 Compare December 16, 2022 23:31

github-actions bot added area/agent/core area/gateway/filter area/gateway/lb area/internal area/manager/index labels Dec 16, 2022

takuyaymd force-pushed the feature/apis/add-flush-api branch from d7c73d2 to dbf27e9 Compare December 19, 2022 04:08

aknishid force-pushed the feature/apis/add-flush-api branch from dbf27e9 to d59271c Compare December 19, 2022 07:09

aknishid force-pushed the feature/apis/add-flush-api branch from d59271c to f655811 Compare January 12, 2023 08:47

aknishid force-pushed the feature/apis/add-flush-api branch from 6c490e6 to 961b327 Compare March 13, 2023 09:58

sonatype-lift bot reviewed Mar 13, 2023

View reviewed changes

aknishid force-pushed the feature/apis/add-flush-api branch from 961b327 to 0393f72 Compare April 7, 2023 06:36

sonatype-lift bot reviewed Apr 7, 2023

View reviewed changes

aknishid force-pushed the feature/apis/add-flush-api branch from d6f247a to a8c8cb6 Compare April 25, 2023 02:15

aknishid force-pushed the feature/apis/add-flush-api branch 4 times, most recently from 23a213b to 7a234aa Compare May 23, 2023 01:37

aknishid force-pushed the feature/apis/add-flush-api branch 2 times, most recently from 4013166 to 8ad592a Compare May 23, 2023 10:20

vankichi added actions/e2e-deploy actions/fossa actions/e2e-chaos actions/e2e-profiling actions/e2e-max-dim and removed actions/e2e-max-dim actions/fossa labels Jul 3, 2023

datelier previously approved these changes Jul 6, 2023

View reviewed changes

kpango previously approved these changes Jul 20, 2023

View reviewed changes

Merge branch 'main' into feature/apis/add-flush-api

355ae00

kpango dismissed stale reviews from datelier, vankichi, and themself via 355ae00 July 20, 2023 06:18

datelier approved these changes Jul 20, 2023

View reviewed changes

vankichi approved these changes Jul 20, 2023

View reviewed changes

kpango approved these changes Jul 20, 2023

View reviewed changes

vankichi added actions/e2e-deploy actions/fossa actions/e2e-chaos actions/e2e-profiling actions/e2e-max-dim and removed actions/e2e-deploy actions/fossa actions/e2e-chaos actions/e2e-profiling actions/e2e-max-dim labels Jul 20, 2023

This was referenced Dec 14, 2023

Add flush API for deleting all vectors #2272

Closed

Add flush API for deleting all vectors #2273

Merged

aknishid closed this Dec 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add flush api #1895

Add flush api #1895

aknishid commented Dec 15, 2022 •

edited

Loading

CLAassistant commented Dec 15, 2022 •

edited

Loading

codecov bot commented Dec 16, 2022 •

edited

Loading

sonatype-lift bot Dec 16, 2022

sonatype-lift bot Dec 16, 2022

sonatype-lift bot Dec 16, 2022

sonatype-lift bot Mar 13, 2023

sonatype-lift bot Apr 7, 2023

kpango left a comment

kpango left a comment

aknishid commented Dec 14, 2023

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

		@@ -21,6 +21,9 @@ var (
		// ErrCreateIndexingIsInProgress represents an error that the indexing is in progress but search request received

Add flush api #1895

Add flush api #1895

Conversation

aknishid commented Dec 15, 2022 • edited Loading

Description:

Related Issue:

Versions:

Checklist:

Special notes for your reviewer:

CLAassistant commented Dec 15, 2022 • edited Loading

codecov bot commented Dec 16, 2022 • edited Loading

Codecov Report

sonatype-lift bot Dec 16, 2022

Choose a reason for hiding this comment

sonatype-lift bot Dec 16, 2022

Choose a reason for hiding this comment

sonatype-lift bot Dec 16, 2022

Choose a reason for hiding this comment

sonatype-lift bot Mar 13, 2023

Choose a reason for hiding this comment

sonatype-lift bot Apr 7, 2023

Choose a reason for hiding this comment

kpango left a comment

Choose a reason for hiding this comment

kpango left a comment

Choose a reason for hiding this comment

aknishid commented Dec 14, 2023

aknishid commented Dec 15, 2022 •

edited

Loading

CLAassistant commented Dec 15, 2022 •

edited

Loading

codecov bot commented Dec 16, 2022 •

edited

Loading