Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deepsource: RVV-A0003 Exit inside non-main function ./hack #1854

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Fix deepsource: RVV-A0003 Exit inside non-main function ./hack #1854

merged 2 commits into from
Nov 21, 2022

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Nov 21, 2022 •
edited
Loading

Description:

I have fixed RVV-A0003 under the hack directory.

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

hlts2
hlts2 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 21, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6f2b11f
Status: ✅  Deploy successful!
Preview URL: https://2f1aa103.vald.pages.dev
Branch Preview URL: https://refactor-rvv-a0003-exit-insi-rc11.vald.pages.dev

View logs

@vankichi vankichi merged commit 3323326 into main Nov 21, 2022
@vankichi vankichi deleted the refactor/RVV-A0003/exit-inside-non-main-function-part2 branch November 21, 2022 15:46
@kpango kpango mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlts2 hlts2 hlts2 approved these changes

@kevindiu kevindiu kevindiu approved these changes

@datelier datelier Awaiting requested review from datelier

Assignees
No one assigned
Labels
priority/low size/S type/refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vankichi @vdaas-ci @kevindiu @hlts2