Fix deepsource: DOK-SC2002, DOK-W1001 Useless cat and Multiple consecutive RUN #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <[email protected]>
|
[CHATOPS:HELP] ChatOps commands.
|
Signed-off-by: hlts2 <[email protected]>
Deploying with
|
| Latest commit: |
145e55d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3546a971.vald.pages.dev |
| Branch Preview URL: | https://refactor-dok-sc2002-delete-c.vald.pages.dev |
Signed-off-by: hlts2 <[email protected]>
hlts2
changed the title
vankichi
reviewed
Nov 21, 2022
Co-authored-by: Kiichiro YUKAWA <[email protected]>
kevindiu
reviewed
Nov 21, 2022
| @@ -67,7 +67,7 @@ SHELL ["/bin/bash", "-o", "pipefail", "-c"] | |||
| RUN GO_VERSION="$(< GO_VERSION)" \ | |||
| && VALD_VERSION="$(< VALD_VERSION)" \ | |||
| && GIT_COMMIT="$(git rev-list -1 HEAD)" \ | |||
| && CPU_INFO_FLAGS="$(cat /proc/cpuinfo | grep flags | cut -d " " -f 2- | head -1)" \ | |||
| && CPU_INFO_FLAGS="$(< /proc/cpuinfo | grep flags | cut -d " " -f 2- | head -1 || true)" \ | |||
There was a problem hiding this comment.
why do we need || true here?
There was a problem hiding this comment.
I fixed it because with set -o pipefail, if you run a head or grep command on the right side of the pipe, the pipe will be closed and a write to the closed pipe will occur, resulting in a SIGPIPE.
kevindiu
approved these changes
Nov 21, 2022
vankichi
approved these changes
Nov 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As titled
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: