Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepsource: RVV-A0003 exit inside non-main function #1838

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

vankichi
Copy link
Contributor

Description:

I have fixed the RVV-A0003 reported by deepsource.

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 30.53% // Head: 30.48% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (f4ad5e0) compared to base (b36a6c4).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1838      +/-   ##
==========================================
- Coverage   30.53%   30.48%   -0.05%     
==========================================
  Files         367      367              
  Lines       33777    33796      +19     
==========================================
- Hits        10313    10302      -11     
- Misses      23048    23076      +28     
- Partials      416      418       +2     
Impacted Files Coverage Δ
hack/license/gen/main.go 0.00% <0.00%> (ø)
internal/info/info.go 88.35% <0.00%> (-0.47%) ⬇️
internal/net/grpc/logger/logger.go 75.00% <0.00%> (-6.82%) ⬇️
...nt/core/ngt/service/vqueue/uninserted_index_map.go 68.30% <0.00%> (-4.92%) ⬇️
pkg/agent/core/ngt/service/option.go 89.57% <0.00%> (-1.85%) ⬇️
internal/worker/queue.go 98.73% <0.00%> (-1.27%) ⬇️
internal/errgroup/group.go 94.00% <0.00%> (-1.00%) ⬇️
internal/worker/worker.go 81.53% <0.00%> (-0.77%) ⬇️
...ent/core/ngt/service/vqueue/undeleted_index_map.go 68.33% <0.00%> (+2.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vankichi vankichi changed the title Refactor [deepsource] RVV-A0003 exit inside non-main function Fix deepsource: RVV-A0003 exit inside non-main function Nov 17, 2022
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 17, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f4ad5e0
Status: ✅  Deploy successful!
Preview URL: https://2a8a2512.vald.pages.dev
Branch Preview URL: https://refactor-rvv-a0003-exit-insi.vald.pages.dev

View logs

Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 9f0f69f into main Nov 18, 2022
@kpango kpango deleted the refactor/RVV-A0003/exit-inside-non-main-function branch November 18, 2022 05:30
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants