Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo comment #1831

Merged
merged 1 commit into from
Nov 17, 2022
Merged

fix typo comment #1831

merged 1 commit into from
Nov 17, 2022

Conversation

datelier
Copy link
Contributor

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 30.54% // Head: 30.55% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (a6bc828) compared to base (ec5a617).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1831      +/-   ##
==========================================
+ Coverage   30.54%   30.55%   +0.01%     
==========================================
  Files         367      367              
  Lines       33777    33777              
==========================================
+ Hits        10316    10321       +5     
+ Misses      23049    23044       -5     
  Partials      412      412              
Impacted Files Coverage Δ
pkg/agent/core/ngt/service/ngt.go 20.14% <50.00%> (ø)
internal/worker/worker.go 82.30% <0.00%> (+0.76%) ⬆️
internal/net/dialer.go 78.40% <0.00%> (+0.99%) ⬆️
internal/errgroup/group.go 95.00% <0.00%> (+1.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kpango kpango merged commit 63e6fcd into main Nov 17, 2022
@kpango kpango deleted the refactoring/agent/fix-typo branch November 17, 2022 06:32
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants