-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix success handling in the half-open and add flow control #1805
Conversation
Signed-off-by: hlts2 <[email protected]>
[CHATOPS:HELP] ChatOps commands.
|
Signed-off-by: hlts2 <[email protected]>
Codecov ReportBase: 50.23% // Head: 30.26% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1805 +/- ##
===========================================
- Coverage 50.23% 30.26% -19.98%
===========================================
Files 231 371 +140
Lines 13464 34011 +20547
===========================================
+ Hits 6764 10294 +3530
- Misses 6499 23302 +16803
- Partials 201 415 +214
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: hlts2 <[email protected]>
Deploying with Cloudflare Pages
|
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
WHAT
As titled
WHY
The rate is not being used properly because the state is being changed immediately on success at half-open. Also, there is no function to limit the flow rate at half-open, so this should be added.
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: