-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] fix metrics bug #1800
[BUG] fix metrics bug #1800
Conversation
Signed-off-by: kpango <[email protected]>
[CHATOPS:HELP] ChatOps commands.
|
Codecov ReportBase: 30.02% // Head: 30.02% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1800 +/- ##
=======================================
Coverage 30.02% 30.02%
=======================================
Files 371 371
Lines 34006 33988 -18
=======================================
- Hits 10209 10205 -4
+ Misses 23383 23368 -15
- Partials 414 415 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙏
LGTM
Deploying with Cloudflare Pages
|
Profile Report
|
Signed-off-by: kpango [email protected]
Description:
v1.6.0 includes rpc status metrics bug, when RPC call succeeds metrics expose the state as Unknown it should be OK Status, so I changed it.
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: