Fix dialer test error #1784
Merged
Fix dialer test error #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kevindiu <[email protected]>
Signed-off-by: kevindiu <[email protected]>
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
area/internal
team/set
Codecov ReportBase: 29.45% // Head: 30.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## test/fix-race-from-1728 #1784 +/- ##
===========================================================
+ Coverage 29.45% 30.31% +0.86%
===========================================================
Files 370 373 +3
Lines 33295 33838 +543
===========================================================
+ Hits 9807 10258 +451
- Misses 23103 23173 +70
- Partials 385 407 +22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: kevindiu <[email protected]>
Deploying with
|
| Latest commit: |
ce14f62
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9b2daa01.vald.pages.dev |
| Branch Preview URL: | https://test-fix-dialer-test-fail.vald.pages.dev |
| @@ -950,7 +958,7 @@ func Test_dialer_cachedDialer(t *testing.T) { | |||
| } | |||
| return nil | |||
| }, | |||
| afterFunc: func(args) { | |||
| afterFunc: func(t *testing.T) { | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
test helper function should start from t.Helper() (thelper)
| }, | ||
| beforeFunc: func(a args) { | ||
| beforeFunc: func(t *testing.T) { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
test helper function should start from t.Helper() (thelper)
| checkFunc: func(w want, c *tls.Conn, err error) error { | ||
| if err == nil { | ||
| return errors.New("Handshake completed even server has been gone") | ||
| } | ||
| return nil | ||
| }, | ||
| afterFunc: func(a args) { | ||
| afterFunc: func(t1 *testing.T) { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
parameter *testing.T should have name t (thelper)
kpango
added a commit
that referenced
this pull request
Sep 8, 2022
* fix test error for PR#1768 Signed-off-by: kpango <[email protected]> * fix index test build error Signed-off-by: kevindiu <[email protected]> * regenerate backup files to fix info test error Signed-off-by: kevindiu <[email protected]> * disable log for save index test to avoid error log Signed-off-by: kevindiu <[email protected]> * fix info test by correct branch name & fix Get() impl Signed-off-by: kevindiu <[email protected]> * Fix dialer test error (#1784) * fix dialer test error Signed-off-by: kevindiu <[email protected]> * revert unnecessary changes Signed-off-by: kevindiu <[email protected]> * correct dialer test impl Signed-off-by: kevindiu <[email protected]> * Fix formatter Signed-off-by: kevindiu <[email protected]> * fix comment Signed-off-by: kevindiu <[email protected]> * remove backup file for test Signed-off-by: kevindiu <[email protected]> Signed-off-by: kpango <[email protected]> Signed-off-by: kevindiu <[email protected]> Co-authored-by: kpango <[email protected]>
kpango
added a commit
that referenced
this pull request
Sep 8, 2022
* fix test error for PR#1768 Signed-off-by: kpango <[email protected]> * fix index test build error Signed-off-by: kevindiu <[email protected]> * regenerate backup files to fix info test error Signed-off-by: kevindiu <[email protected]> * disable log for save index test to avoid error log Signed-off-by: kevindiu <[email protected]> * fix info test by correct branch name & fix Get() impl Signed-off-by: kevindiu <[email protected]> * Fix dialer test error (#1784) * fix dialer test error Signed-off-by: kevindiu <[email protected]> * revert unnecessary changes Signed-off-by: kevindiu <[email protected]> * correct dialer test impl Signed-off-by: kevindiu <[email protected]> * Fix formatter Signed-off-by: kevindiu <[email protected]> * fix comment Signed-off-by: kevindiu <[email protected]> * remove backup file for test Signed-off-by: kevindiu <[email protected]> Signed-off-by: kpango <[email protected]> Signed-off-by: kevindiu <[email protected]> Co-authored-by: kpango <[email protected]> Signed-off-by: kpango <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
SSIA
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: