add backup configuration document #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vankichi <[email protected]>
|
[CHATOPS:HELP] ChatOps commands.
|
Deploying with
|
| Latest commit: |
4f121bf
|
| Status: | ⚡️ Build in progress... |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: vankichi <[email protected]>
vankichi
force-pushed
the
documentation/docs/add-backup-config-document
branch
from
1f37ac1 to
a68e0db
Compare
vankichi
requested review from
kevindiu,
a team and
datelier
and removed request for
a team
kevindiu
reviewed
Aug 2, 2022
kevindiu
reviewed
Aug 2, 2022
Co-authored-by: Kevin Diu <[email protected]>
Co-authored-by: Kevin Diu <[email protected]>
datelier
previously approved these changes
Aug 3, 2022
kevindiu
previously approved these changes
Aug 3, 2022
vankichi
dismissed stale reviews from kevindiu and datelier
The base branch was changed.
datelier
previously approved these changes
Aug 9, 2022
kevindiu
previously approved these changes
Aug 9, 2022
|
It would be better to add 4 points.
|
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vankichi <[email protected]>
kpango
reviewed
Aug 25, 2022
kpango
reviewed
Aug 25, 2022
kpango
reviewed
Aug 25, 2022
| # accessMode for PV (please verify your environment) | ||
| accessMode: ReadWriteOncePod | ||
| # storage class for PV (please verify your environment) | ||
| storageClass: local-path |
There was a problem hiding this comment.
I think it would be better to set GKE storage class and configuration as a sample.
Co-authored-by: Yusuke Kato <[email protected]>
Signed-off-by: vankichi <[email protected]>
kevindiu
reviewed
Aug 29, 2022
kevindiu
approved these changes
Aug 29, 2022
datelier
approved these changes
Aug 30, 2022
kpango
approved these changes
Aug 31, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
SSIA
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: