Add Circuit Breaker implementation #1738
Conversation
Signed-off-by: hlts2 <[email protected]>
|
[WARNING:INTCFG] Changes in |
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
area/gateway/lb
area/helm
area/internal
area/manager/index
size/XL
type/feature
Codecov Report
@@ Coverage Diff @@
## master #1738 +/- ##
==========================================
- Coverage 31.64% 31.27% -0.37%
==========================================
Files 372 381 +9
Lines 32313 32698 +385
==========================================
+ Hits 10224 10225 +1
- Misses 21696 22071 +375
- Partials 393 402 +9
Continue to review full report at Codecov.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
golangci
internal/circuitbreaker/breaker.go|105 col 6| variable name 'ok' is too short for the scope of its usage (varnamelen)
internal/circuitbreaker/manager.go|48 col 6| variable name 'st' is too short for the scope of its usage (varnamelen)
internal/circuitbreaker/breaker.go|106 col 6| variable name 'st' is too short for the scope of its usage (varnamelen)
internal/circuitbreaker/options.go|95 col 14| parameter name 'b' is too short for the scope of its usage (varnamelen)
internal/circuitbreaker/options.go|112 col 14| parameter name 'b' is too short for the scope of its usage (varnamelen)
internal/observability/metrics/circuitbreaker/circuitbreaker.go|57 col 2| variable name 'ms' is too short for the scope of its usage (varnamelen)
| ) | ||
|
|
||
| func (s State) String() string { | ||
| switch s { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
missing cases in switch of type State: StateUnknown (exhaustive)
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Deploying with
|
| Latest commit: |
8ce5e1a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0dda5d95.vald.pages.dev |
| Branch Preview URL: | https://feature-add-circuit-breaker-.vald.pages.dev |
Signed-off-by: hlts2 <[email protected]>
| return nil | ||
| } | ||
| tests := []test{ | ||
| // TODO test cases |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
internal/errors/circuitbreaker_test.go:47: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
| }, | ||
| */ | ||
|
|
||
| // TODO test cases |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
internal/errors/circuitbreaker_test.go:59: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
| return nil | ||
| } | ||
| tests := []test{ | ||
| // TODO test cases |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
internal/errors/circuitbreaker_test.go:120: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
| }, | ||
| */ | ||
|
|
||
| // TODO test cases |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
internal/errors/circuitbreaker_test.go:132: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
| return nil | ||
| } | ||
| tests := []test{ | ||
| // TODO test cases |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
internal/errors/circuitbreaker_test.go:196: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
|
|
||
| // Do invokes the breaker matching the given key. | ||
| func (bm *breakerManager) Do(ctx context.Context, key string, fn func(ctx context.Context) (interface{}, error)) (val interface{}, err error) { | ||
| var st State |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
variable name 'st' is too short for the scope of its usage (varnamelen)
| cnt.onFail() | ||
|
|
||
| var ok bool | ||
| var st State |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
variable name 'st' is too short for the scope of its usage (varnamelen)
| cnt := b.count.Load().(*count) | ||
| cnt.onFail() | ||
|
|
||
| var ok bool |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
variable name 'ok' is too short for the scope of its usage (varnamelen)
| // WithOpenTimeout returns an option that sets the timeout of "Open" state. | ||
| // After this period, the state will be changed from "Open" to "HalfOpen". | ||
| func WithOpenTimeout(timeout string) BreakerOption { | ||
| return func(b *breaker) error { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
parameter name 'b' is too short for the scope of its usage (varnamelen)
| // WithClosedRefreshTimeout returns an option that sets the timeout of "Closed" state. | ||
| // After this period, the counter will be refreshed. | ||
| func WithClosedRefreshTimeout(timeout string) BreakerOption { | ||
| return func(b *breaker) error { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
parameter name 'b' is too short for the scope of its usage (varnamelen)
| type args struct { | ||
| opts []BreakerOption | ||
| } | ||
| type want struct { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
type want is unused (unused)
hlts2
changed the title
Description:
WHY
When checking backoff metrics with Grafana, I noticed a large number of unnecessary backoff retries.
WHAT
I developed the Circuit Breaker function to prevent a large number of unnecessary retries.
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: