Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add distance type #1732

Merged
merged 2 commits into from
Jul 15, 2022
Merged

add distance type #1732

merged 2 commits into from
Jul 15, 2022

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Jul 14, 2022

Signed-off-by: kpango [email protected]

Description:

added NGT Distance Type below

  • Poincare
  • Lorentz
  • SparseJaccard
  • NormalizedL2

This PR can merge after yahoojapan/NGT#120 released.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.6

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vdaas-ci
Copy link
Collaborator

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

@kpango kpango changed the title add distance type [Do not merge] add distance type Jul 14, 2022
Signed-off-by: kpango <[email protected]>
@kpango kpango force-pushed the feature/agent/add-distance-type branch from ed961c4 to e26c65d Compare July 14, 2022 05:43
@kpango kpango marked this pull request as ready for review July 14, 2022 05:43
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #1732 (9e5a340) into master (fbe44bc) will decrease coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1732      +/-   ##
==========================================
- Coverage   31.58%   31.24%   -0.34%     
==========================================
  Files         371      346      -25     
  Lines       32264    27657    -4607     
==========================================
- Hits        10191     8642    -1549     
+ Misses      21683    18748    -2935     
+ Partials      390      267     -123     
Impacted Files Coverage Δ
internal/config/ngt.go 100.00% <ø> (ø)
...ent/core/ngt/service/vqueue/undeleted_index_map.go 68.33% <0.00%> (-2.78%) ⬇️
...nt/core/ngt/service/vqueue/uninserted_index_map.go 70.49% <0.00%> (-2.74%) ⬇️
internal/core/algorithm/ngt/ngt.go
internal/core/algorithm/ngt/option.go
pkg/agent/core/ngt/handler/grpc/index.go
pkg/agent/core/ngt/service/option.go
pkg/agent/core/ngt/handler/grpc/upsert.go
pkg/agent/core/ngt/handler/rest/handler.go
pkg/agent/core/ngt/handler/grpc/update.go
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec27c8...9e5a340. Read the comment docs.

@kpango kpango requested review from datelier and hlts2 July 14, 2022 07:33
hlts2
hlts2 previously approved these changes Jul 14, 2022
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: kpango <[email protected]>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 15, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9e5a340
Status: ✅  Deploy successful!
Preview URL: https://734ed91f.vald.pages.dev
Branch Preview URL: https://feature-agent-add-distance-t.vald.pages.dev

View logs

@kpango kpango changed the title [Do not merge] add distance type add distance type Jul 15, 2022
@kpango kpango merged commit 3227058 into master Jul 15, 2022
@kpango kpango deleted the feature/agent/add-distance-type branch July 15, 2022 09:13
@hlts2 hlts2 mentioned this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants