Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different id returned when GetObject RPC and Exists RPC #1709

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Jun 22, 2022

Description:

WHAT

I fixed GetObject RPC and Exists RPC to return the same type of ID. (uuid)

WHY

The different ID type are returned when the user called GetObject RPC and Exists RPC.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.6

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango requested review from kevindiu and datelier June 22, 2022 08:01
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1709 (c0d99fc) into master (59c0a2c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1709      +/-   ##
==========================================
+ Coverage   31.47%   31.50%   +0.02%     
==========================================
  Files         385      385              
  Lines       32679    32676       -3     
==========================================
+ Hits        10286    10294       +8     
+ Misses      22002    21992      -10     
+ Partials      391      390       -1     
Impacted Files Coverage Δ
pkg/agent/core/ngt/handler/grpc/object.go 28.77% <100.00%> (-1.51%) ⬇️
internal/worker/worker.go 84.37% <0.00%> (+0.78%) ⬆️
...nt/core/ngt/service/vqueue/uninserted_index_map.go 78.68% <0.00%> (+5.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 417abed...c0d99fc. Read the comment docs.

@hlts2 hlts2 merged commit a41df5e into master Jun 22, 2022
@hlts2 hlts2 deleted the bugfix/pkg/agent-different-id-returned branch June 22, 2022 10:25
kevindiu pushed a commit that referenced this pull request Jul 4, 2022
@kevindiu kevindiu mentioned this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants