[bugfix] return NotFound error when delete fails in multiUpdate

[vankichi]

Signed-off-by: vankichi [email protected]

Description:

The delete index function runs in the multiUpdate, but it does not return NotFound error when the index does not exist in pkg/agent/core/ngt layer.
It affects when vald agent standalone.
This PR changes the flag validation as true to return NotFound error.

In addition, I have fixed the readyForUpdate method.
When the error occurs in GetObject(), which readyForUpdate calls, readyForUpdate returns error.

Related Issue:

How Has This Been Tested?:

Environment:

• Go Version: 1.18.2
• Docker Version: 20.10.8
• Kubernetes Version: 1.22.0
• NGT Version: 1.14.5

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - replace the PR body by changelog details
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase master
• 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

[codecov]

Codecov Report

Merging #1681 (2a01149) into master (46334b2) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1681      +/-   ##
==========================================
- Coverage   31.20%   31.17%   -0.04%     
==========================================
  Files         372      372              
  Lines       32502    32503       +1     
==========================================
- Hits        10142    10132      -10     
- Misses      21982    21990       +8     
- Partials      378      381       +3     

Impacted Files	Coverage Δ
pkg/agent/core/ngt/service/ngt.go	20.22% <33.33%> (-0.23%)	⬇️
...nt/core/ngt/service/vqueue/uninserted_index_map.go	75.95% <0.00%> (-2.74%)	⬇️
pkg/agent/core/ngt/service/option.go	89.57% <0.00%> (-1.85%)	⬇️
internal/worker/worker.go	83.59% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3f0823...2a01149. Read the comment docs.

[kpango]

LGTM

[hlts2]

LGTM!

[hlts2]

LGTM!!