-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add api status code description #1679
Conversation
[CHATOPS:HELP] ChatOps commands.
|
75c912c
to
8cb56c9
Compare
8cb56c9
to
7a706ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
LanguageTool
docs/api/search.md|698 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/search.md|743 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|786 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|831 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|874 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/search.md|933 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|976 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|1035 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|1091 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/search.md|1146 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|1203 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|1258 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/update.md|66 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/update.md|67 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/update.md|152 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/update.md|153 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/update.md|188 col 59| In standard English, the word ‘exists’ is a verb. Please verify that the determiner ‘the’ is correct, or that a noun is not missing between ‘the’ and ‘exists’. (A_INFINITIVE[3])
URL: https://languagetool.org/insights/post/verbs-as-nouns/
Rule: https://community.languagetool.org/rule/show/A_INFINITIVE?lang=en-US&subId=3
Category: GRAMMAR
docs/api/update.md|271 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/update.md|272 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/upsert.md|70 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/upsert.md|71 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/upsert.md|155 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/upsert.md|156 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/upsert.md|273 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/upsert.md|274 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
85d552d
to
b2c4e90
Compare
Signed-off-by: vankichi <[email protected]>
b2c4e90
to
e4c813d
Compare
Signed-off-by: vankichi <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Kato <[email protected]>
Signed-off-by: vankichi <[email protected]>
…ub.com/vdaas/vald into documentation/docs/add-api-status-code
…ub.com/vdaas/vald into documentation/docs/add-api-status-code
Signed-off-by: vankichi <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: vankichi [email protected]
Description:
I have created the gRPC status code overview document for the Vald cluster.
If there are more status codes that we are possible to get, let me know.
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: