Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DONT MERGE] Add logic to get backoff metrics #1666
[DONT MERGE] Add logic to get backoff metrics #1666
Changes from 8 commits
421501d
e98669a
3320531
57fb78c
6f549bb
9315c0e
2a98372
88b2cce
307e271
c432624
eb6f54a
2893de0
66009b6
d4a4cbd
0a7133d
7fcbe9d
9534597
db7bd9d
bf913f9
d94cdae
702ece8
999dde4
54f3ab3
014b128
ea9e40e
66e5eac
e1e0e27
f4899ef
5c7af01
00d9988
f98545a
012b8b3
cbffcda
ed8ff25
1fbe737
acc4711
5003cbb
1a90ecc
e4fc27f
d1c5e7e
e1dc9d5
a925c68
6d5261b
e92afd7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
fieldalignment: struct with 48 pointer bytes could be 32 (govet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
named return "mts" with type "[]metrics.MeasurementWithTags" found (nonamedreturns)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have fixed function name because of CI fails.
The reason why CI fails was because there was a same function in to the same package.
https://github.com/vdaas/vald/blob/master/internal/runner/runner_test.go#L284