Implement multi insert test case for pkg agent handler - part 2 #1645

kevindiu · 2022-05-10T01:29:01Z

Description:

This PR implements pkg agent ngt multi insert test case (part 2).
I will create another PR to implement the remaining test cases.

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.18.1
Docker Version: 20.10.8
Kubernetes Version: 1.22.0
NGT Version: 1.14.3

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

Signed-off-by: kevindiu <[email protected]>

vdaas-ci · 2022-05-10T01:29:15Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - replace the PR body by changelog details
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

codecov · 2022-05-10T01:36:45Z

Codecov Report

Merging #1645 (b75aab8) into test/pkg/add-pkg-agent-handler-multi-insert-test (2a7b4da) will increase coverage by 0.12%.
The diff coverage is n/a.

@@                                 Coverage Diff                                  @@
##           test/pkg/add-pkg-agent-handler-multi-insert-test    #1645      +/-   ##
====================================================================================
+ Coverage                                             30.66%   30.78%   +0.12%     
====================================================================================
  Files                                                   372      372              
  Lines                                                 32234    32234              
====================================================================================
+ Hits                                                   9883     9924      +41     
+ Misses                                                21986    21941      -45     
- Partials                                                365      369       +4

Impacted Files	Coverage Δ
pkg/agent/core/ngt/service/option.go	`89.57% <0.00%> (-1.85%)`	⬇️
internal/worker/worker.go	`83.59% <0.00%> (-1.57%)`	⬇️
internal/errgroup/group.go	`95.00% <0.00%> (+1.00%)`	⬆️
pkg/agent/core/ngt/service/ngt.go	`20.44% <0.00%> (+1.11%)`	⬆️
pkg/agent/core/ngt/handler/grpc/handler.go	`12.19% <0.00%> (+1.30%)`	⬆️
internal/worker/queue.go	`98.73% <0.00%> (+2.53%)`	⬆️
internal/backoff/backoff.go	`87.95% <0.00%> (+7.22%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a7b4da...b75aab8. Read the comment docs.

Signed-off-by: kevindiu <[email protected]>

pkg/agent/core/ngt/handler/grpc/handler_test.go

Signed-off-by: kevindiu <[email protected]>

pkg/agent/core/ngt/handler/grpc/handler_test.go

Signed-off-by: kevindiu <[email protected]>

* impl multiinsert boundary value test (part1) Signed-off-by: kevindiu <[email protected]> * impl remaining tests Signed-off-by: kevindiu <[email protected]> * change max dim Signed-off-by: kevindiu <[email protected]> * change max dim to reference value Signed-off-by: kevindiu <[email protected]> * change max dim to reference value Signed-off-by: kevindiu <[email protected]> * fix comments Signed-off-by: kevindiu <[email protected]> * rename help function name Signed-off-by: kevindiu <[email protected]> * combine genXXXInsertReq function Signed-off-by: kevindiu <[email protected]> * rename helper function name Signed-off-by: kevindiu <[email protected]>

* draft part of test case for multi insert Signed-off-by: kevindiu <[email protected]> * fix comments and add decision table test cases Signed-off-by: kevindiu <[email protected]> * fix decision table test case name Signed-off-by: kevindiu <[email protected]> * update test case name Signed-off-by: kevindiu <[email protected]> * Update pkg/agent/core/ngt/handler/grpc/handler_test.go Co-authored-by: Kosuke Morimoto <[email protected]> * Implement multi insert test case for pkg agent handler - part 1 (#1630) * impl multiinsert Equivalence Class Testing Signed-off-by: kevindiu <[email protected]> * Implement multi insert test case for pkg agent handler - part 2 (#1645) * impl multiinsert boundary value test (part1) Signed-off-by: kevindiu <[email protected]> * impl remaining tests Signed-off-by: kevindiu <[email protected]> * change max dim Signed-off-by: kevindiu <[email protected]> * change max dim to reference value Signed-off-by: kevindiu <[email protected]> * change max dim to reference value Signed-off-by: kevindiu <[email protected]> * fix comments Signed-off-by: kevindiu <[email protected]> * rename help function name Signed-off-by: kevindiu <[email protected]> * combine genXXXInsertReq function Signed-off-by: kevindiu <[email protected]> * rename helper function name Signed-off-by: kevindiu <[email protected]> * Implement multi insert test case for pkg agent handler - part 3 (#1646) * impl multiinsert test part 3 Signed-off-by: kevindiu <[email protected]> * fix comment Signed-off-by: kevindiu <[email protected]> * fix comment Signed-off-by: kevindiu <[email protected]> * Implement multi insert test case for pkg agent handler - part 4 (#1651) * implement tests Signed-off-by: kevindiu <[email protected]> * implement remaining tests Signed-off-by: kevindiu <[email protected]> * Update pkg/agent/core/ngt/handler/grpc/handler_test.go Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix comment Signed-off-by: kevindiu <[email protected]> * Update pkg/agent/core/ngt/handler/grpc/handler_test.go Co-authored-by: Kiichiro YUKAWA <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kiichiro YUKAWA <[email protected]> * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <[email protected]> * fix comment Signed-off-by: kevindiu <[email protected]> * fix comment Signed-off-by: kevindiu <[email protected]> * fix comment Signed-off-by: kevindiu <[email protected]> * fix comment Signed-off-by: kevindiu <[email protected]> * fix comment Signed-off-by: kevindiu <[email protected]> * fix comment Signed-off-by: kevindiu <[email protected]> Co-authored-by: Kosuke Morimoto <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kiichiro YUKAWA <[email protected]>

impl multiinsert boundary value test (part1)

58f9d1e

Signed-off-by: kevindiu <[email protected]>

github-actions bot added area/agent/core team/set SET team size/XL type/test Adding tests priority/low labels May 10, 2022

impl remaining tests

1de4e3f

Signed-off-by: kevindiu <[email protected]>

github-actions bot added size/XXL and removed size/XL labels May 10, 2022

kevindiu added 3 commits May 10, 2022 13:29

change max dim

8662ec8

Signed-off-by: kevindiu <[email protected]>

change max dim to reference value

bf5ac3c

Signed-off-by: kevindiu <[email protected]>

change max dim to reference value

d74edbc

Signed-off-by: kevindiu <[email protected]>

kevindiu marked this pull request as ready for review May 10, 2022 06:03

kevindiu changed the title ~~[WIP] Implement multi insert test case for pkg agent handler - part 2~~ Implement multi insert test case for pkg agent handler - part 2 May 10, 2022

kevindiu requested review from kmrmt and vankichi May 10, 2022 06:04

vankichi reviewed May 11, 2022

View reviewed changes

kevindiu mentioned this pull request May 11, 2022

Implement multi insert test case for pkg agent handler #1612

Merged

18 tasks

fix comments

297e331

Signed-off-by: kevindiu <[email protected]>

kevindiu requested a review from vankichi May 11, 2022 08:39

kmrmt approved these changes May 11, 2022

View reviewed changes

vankichi reviewed May 12, 2022

View reviewed changes

pkg/agent/core/ngt/handler/grpc/handler_test.go Outdated Show resolved Hide resolved

rename help function name

c19dd5c

Signed-off-by: kevindiu <[email protected]>

kevindiu requested a review from vankichi May 12, 2022 06:05

kevindiu added 2 commits May 12, 2022 15:51

combine genXXXInsertReq function

104eb48

Signed-off-by: kevindiu <[email protected]>

rename helper function name

b75aab8

Signed-off-by: kevindiu <[email protected]>

vankichi approved these changes May 12, 2022

View reviewed changes

kevindiu merged commit 1a298b4 into test/pkg/add-pkg-agent-handler-multi-insert-test May 12, 2022

kevindiu deleted the test/pkg/add-pkg-agent-handler-multi-insert-test-part2 branch May 12, 2022 07:46

kevindiu restored the test/pkg/add-pkg-agent-handler-multi-insert-test-part2 branch May 12, 2022 07:47

kevindiu deleted the test/pkg/add-pkg-agent-handler-multi-insert-test-part2 branch June 20, 2022 09:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement multi insert test case for pkg agent handler - part 2 #1645

Implement multi insert test case for pkg agent handler - part 2 #1645

kevindiu commented May 10, 2022 •

edited

Loading

vdaas-ci commented May 10, 2022

codecov bot commented May 10, 2022 •

edited

Loading

Implement multi insert test case for pkg agent handler - part 2 #1645

Implement multi insert test case for pkg agent handler - part 2 #1645

Conversation

kevindiu commented May 10, 2022 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

vdaas-ci commented May 10, 2022

codecov bot commented May 10, 2022 • edited Loading

Codecov Report

kevindiu commented May 10, 2022 •

edited

Loading

codecov bot commented May 10, 2022 •

edited

Loading