Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Happy new year #1525

Merged
merged 1 commit into from
Jan 1, 2022
Merged

Happy new year #1525

merged 1 commit into from
Jan 1, 2022

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Dec 31, 2021

Signed-off-by: hlts2 [email protected]

Description:

Happy new year!!!
I updated the license with the following command.
https://github.com/kpango/dotfiles/blob/master/zshrc#L1251-L1267

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.17.5
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.13.8

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: hlts2 <[email protected]>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@hlts2 hlts2 requested review from kpango and kevindiu December 31, 2021 15:29
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy 2022! LGTM

@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #1525 (ea56691) into master (12ded06) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1525      +/-   ##
==========================================
- Coverage   30.03%   29.91%   -0.13%     
==========================================
  Files         367      367              
  Lines       22118    22118              
==========================================
- Hits         6644     6617      -27     
- Misses      15173    15194      +21     
- Partials      301      307       +6     
Impacted Files Coverage Δ
cmd/agent/core/ngt/main.go 0.00% <ø> (ø)
cmd/agent/sidecar/main.go 0.00% <ø> (ø)
cmd/discoverer/k8s/main.go 0.00% <ø> (ø)
cmd/filter/ingress/tensorflow/main.go 0.00% <ø> (ø)
cmd/gateway/filter/main.go 0.00% <ø> (ø)
cmd/gateway/lb/main.go 0.00% <ø> (ø)
cmd/manager/index/main.go 0.00% <ø> (ø)
cmd/tools/cli/loadtest/main.go 0.00% <ø> (ø)
hack/benchmark/assets/x1b/loader.go 0.00% <ø> (ø)
hack/benchmark/core/benchmark/benchmark.go 0.00% <ø> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfaacf8...ea56691. Read the comment docs.

Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy New Year !!!
LGTM

@hlts2 hlts2 merged commit 38b8d59 into master Jan 1, 2022
@hlts2 hlts2 deleted the feature/license/happy-new-year-2022 branch January 1, 2022 07:25
@hlts2
Copy link
Collaborator Author

hlts2 commented Jan 1, 2022

@kpango @vankichi
Thank you for the review! I merged this PR!

@vankichi vankichi mentioned this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants