Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] append timing of vqueue existing map #1264

Merged
merged 4 commits into from
May 31, 2021

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented May 31, 2021

Signed-off-by: kpango [email protected]

Description:

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.16.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.3

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kpango kpango force-pushed the bugfix/agent/vqueue-exists-check-map-append-timimng branch from 2041d7c to 5ad6ebc Compare May 31, 2021 09:11
hlts2
hlts2 previously approved these changes May 31, 2021
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #1264 (f05499b) into master (e61079c) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head f05499b differs from pull request most recent head b79f99f. Consider uploading reports for the commit b79f99f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
+ Coverage   17.95%   18.00%   +0.04%     
==========================================
  Files         503      501       -2     
  Lines       31746    31521     -225     
==========================================
- Hits         5701     5675      -26     
+ Misses      25726    25527     -199     
  Partials      319      319              
Impacted Files Coverage Δ
internal/worker/worker.go 83.33% <0.00%> (-1.05%) ⬇️
pkg/agent/core/ngt/service/vqueue/option.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e61079c...b79f99f. Read the comment docs.

Signed-off-by: kpango <[email protected]>
kevindiu
kevindiu previously approved these changes May 31, 2021
hlts2
hlts2 previously approved these changes May 31, 2021
Signed-off-by: kpango <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants