Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resource type infos to grpc error response #1262

Merged
merged 3 commits into from
May 31, 2021

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented May 30, 2021

Signed-off-by: kpango [email protected]

Description:

add resource type infos to grpc error response

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.16.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.3

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented May 30, 2021

Codecov Report

Merging #1262 (0a6bb53) into master (f6de759) will decrease coverage by 0.64%.
The diff coverage is 3.69%.

❗ Current head 0a6bb53 differs from pull request most recent head a620839. Consider uploading reports for the commit a620839 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1262      +/-   ##
==========================================
- Coverage   18.09%   17.44%   -0.65%     
==========================================
  Files         503      500       -3     
  Lines       31611    31391     -220     
==========================================
- Hits         5720     5477     -243     
- Misses      25587    25617      +30     
+ Partials      304      297       -7     
Impacted Files Coverage Δ
pkg/agent/core/ngt/handler/grpc/handler.go 0.00% <0.00%> (ø)
pkg/discoverer/k8s/handler/grpc/handler.go 0.00% <0.00%> (ø)
pkg/gateway/lb/handler/grpc/handler.go 0.00% <0.00%> (ø)
pkg/gateway/meta/handler/grpc/handler.go 0.00% <0.00%> (ø)
pkg/discoverer/k8s/handler/grpc/option.go 15.78% <20.00%> (+15.78%) ⬆️
pkg/gateway/lb/handler/grpc/option.go 10.71% <27.27%> (+10.71%) ⬆️
pkg/gateway/meta/handler/grpc/option.go 13.04% <27.27%> (+13.04%) ⬆️
internal/runner/runner.go 87.93% <100.00%> (ø)
internal/worker/worker.go 82.29% <0.00%> (-1.05%) ⬇️
internal/net/net.go
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e01f788...a620839. Read the comment docs.

Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit e61079c into master May 31, 2021
@kpango kpango deleted the refactor/status-code/handling-status-and-error branch May 31, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants