-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add remove sample code for tutorial #1053
add remove sample code for tutorial #1053
Conversation
[CHATOPS:HELP] ChatOps commands.
|
acbd033
to
1a89537
Compare
docs/tutorial/get-started.md
Outdated
|
||
|
||
- Remove manually instead of waiting for auto indexing. | ||
If you run below code, the indexes will be removed from the Vald Agent and the Backup file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I through the eyes of the user, I thought that CreateIndex
would mean deleting the file, so what about the following?. if I made a mistake, I am sorry...
If you run below code, the indexes will be removed from the Vald Agent and the Backup file. | |
If you run below code, the indexes will be removed from the Vald Agent and the Backup file because you deleted all the inserted vectors in the above section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, Should we change from SaveIndex
to SaveAndCreateIndex
method.
Will the backup file be erased, but will the indexing data be erased as well? 🤔
I made a mistake, I am sorry...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hlts2 @kevindiu
I think CreateAndSaveIndex()
won't work well.
cuz, there is no index to create and save.
I just tried to use CreateAndSaveIndex()
instead of the current implementation, but end with the error FailedPreCondition desc = CreateAndSaveIndex API failed to create indexes pool_size = 400
.
If you can, could you please try it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hlts2 @kevindiu
I should announce to guys that the current vald-agent=ngt:latest
image will not work well, so if you'd like to confirm the tutorial, please use the nightly
version.
The latest version will be updated when released next version.
And also, CreateAndSaveIndex()
is good. but, this time, I'd like to use another method as SaveIndex()
instead of this to show vald client does not have only CreateAndSaveIndex()
.
How do you think about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rebase |
[REBASE] Rebase triggered by kevindiu for branch: documentation/docs/add-remove-index-sec-for-tutorial |
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vankichi <[email protected]>
Co-authored-by: Kevin Diu <[email protected]>
Co-authored-by: Kevin Diu <[email protected]>
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vankichi <[email protected]>
32685bd
to
9ae9ae3
Compare
[FORMAT] Updating license headers and formatting go codes triggered by kevindiu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVED] This PR is approved by kevindiu.
Signed-off-by: vankichi [email protected]
Description:
Since #1050 , I added the removing index section for sample codes.
also, updated the
doc/tutorial/get-started.md
along with above changes.I already confirmed these sample codes run well in my local environment (docker and k3d).
I appreciate it if you try
Get-Started
too.Related Issue:
#1050
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: