-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove not supported control flag on darwin #1025
remove not supported control flag on darwin #1025
Conversation
Signed-off-by: kpango <[email protected]>
[CHATOPS:HELP] ChatOps commands.
|
if ierr != nil { | ||
err = errors.Wrap(err, ierr.Error()) | ||
} | ||
if isTCP(network) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶if isTCP(network)
is deeply nested (complexity: 18) (nestif)
if ierr != nil { | ||
err = errors.Wrap(err, ierr.Error()) | ||
} | ||
if ctrl.keepAlive > 0 && isTCP(network) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶if ctrl.keepAlive > 0 && isTCP(network)
is deeply nested (complexity: 6) (nestif)
Codecov Report
@@ Coverage Diff @@
## master #1025 +/- ##
==========================================
- Coverage 14.84% 14.83% -0.01%
==========================================
Files 497 497
Lines 28638 28649 +11
==========================================
- Hits 4252 4251 -1
- Misses 24117 24128 +11
- Partials 269 270 +1
Continue to review full report at Codecov.
|
/rebase |
[REBASE] Rebase triggered by kevindiu for branch: bugfix/internal-net-control/resolve-undefined-on-darwin |
Signed-off-by: kpango <[email protected]>
5be72b9
to
087c4c9
Compare
Signed-off-by: kpango <[email protected]>
…' of https://github.com/vdaas/vald into bugfix/internal-net-control/resolve-undefined-on-darwin
Signed-off-by: kpango [email protected]
Description:
bugfix internal/net/control on darwin os
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: