Skip to content

Commit

Permalink
♻️ apply feedback
Browse files Browse the repository at this point in the history
Signed-off-by: vankichi <[email protected]>
  • Loading branch information
vankichi committed Sep 17, 2022
1 parent 277ae40 commit f66fc22
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions internal/k8s/benchmark/job/job.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ type reconciler struct {
func New(opts ...Option) BenchmarkJobWatcher {
r := new(reconciler)
for _, opt := range append(defaultOpts, opts...) {
// TODO: impl error handling after implement functional option
opt(r)
}
return r
Expand Down
1 change: 1 addition & 0 deletions internal/k8s/benchmark/operator/operator.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ type reconciler struct {
func New(opts ...Option) BenchmarkOperatorWatcher {
r := new(reconciler)
for _, opt := range append(defaultOpts, opts...) {
// TODO: impl error handling after implement functional option
opt(r)
}
return r
Expand Down
6 changes: 3 additions & 3 deletions internal/k8s/benchmark/operator/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ type BenchmarkOperatorSpec struct {
type BenchmarkOperatorStatus string

const (
BenchmarkOperatorNotReady = BenchmarkOperatorStatus("NotReady")
BenchmarkOperatorAvailable = BenchmarkOperatorStatus("Available")
BenchmarkOperatorHealthy = BenchmarkOperatorStatus("Healthy")
BenchmarkOperatorNotReady BenchmarkOperatorStatus = "NotReady"
BenchmarkOperatorAvailable BenchmarkOperatorStatus = "Available"
BenchmarkOperatorHealthy BenchmarkOperatorStatus = "Healthy"
)

type BenchmarkOperator struct {
Expand Down

0 comments on commit f66fc22

Please sign in to comment.