Skip to content

Commit

Permalink
Update comment
Browse files Browse the repository at this point in the history
  • Loading branch information
ykadowak committed Feb 9, 2024
1 parent 6c00bdd commit dac10af
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions dockers/dev/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@
ARG MAINTAINER="vdaas.org vald team <[email protected]>"

# skipcq: DOK-DL3026
# Ubuntu is not supported by a lot of devcontainer features like `docker-in-docker`, so we should stick to official debian based ones
# https://github.com/devcontainers/features/blob/08fb370a59cc311d9f81a9e90be33cf2e6648baa/src/docker-in-docker/install.sh#L123
# FIXME: change the tag to :1 when they support go 1.22
# we should stick to official devcontainers as a base image because it is well tested to be used with the vscode devcontainer extension.
FROM --platform=${BUILDPLATFORM} mcr.microsoft.com/vscode/devcontainers/base:debian
LABEL maintainer="${MAINTAINER}"

Expand Down

0 comments on commit dac10af

Please sign in to comment.