fix DeepSource issue: Empty string test can be improved

Signed-off-by: datelier <[email protected]>
vdaas · Jul 9, 2020 · ba92ef5 · ba92ef5
1 parent 722a9a9
commit ba92ef5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/core/converter/tensorflow/option_test.go b/internal/core/converter/tensorflow/option_test.go
@@ -508,7 +508,7 @@ func TestWithLoadFunc(t *testing.T) {
 			cmp.AllowUnexported(OutputSpec{}),
 			cmpopts.IgnoreFields(tensorflow{}, "loadFunc"),
 		}
-		if diff := cmp.Diff(w.obj, obj, opts...); len(diff) != 0 {
+		if diff := cmp.Diff(w.obj, obj, opts...); diff != "" {
 			return errors.Errorf("err: %s", diff)
 		}
 		opt := cmp.Comparer(func(want, obj T) bool {

diff --git a/internal/core/converter/tensorflow/tensorflow_test.go b/internal/core/converter/tensorflow/tensorflow_test.go
@@ -58,7 +58,7 @@ func TestNew(t *testing.T) {
 			cmp.AllowUnexported(OutputSpec{}),
 			cmpopts.IgnoreFields(tensorflow{}, "loadFunc"),
 		}
-		if diff := cmp.Diff(w.want, got, opts...); len(diff) != 0 {
+		if diff := cmp.Diff(w.want, got, opts...); diff != "" {
 			return errors.Errorf("err: %s", diff)
 		}
 		opt := cmp.Comparer(func(want, got TF) bool {