♻️ stop all exporters & profilers if initialize failed

Signed-off-by: Rintaro Okamura <[email protected]>
vdaas · Jun 18, 2020 · b7fe0ed · b7fe0ed
1 parent 048c43e
commit b7fe0ed
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/internal/observability/observability.go b/internal/observability/observability.go
@@ -212,16 +212,25 @@ func (o *observability) PreStart(ctx context.Context) (err error) {
 		return err
 	}
 
-	for _, ex := range o.exporters {
+	for i, ex := range o.exporters {
 		err = ex.Start(ctx)
 		if err != nil {
+			for _, ex = range o.exporters[:i] {
+				ex.Stop(ctx)
+			}
 			return err
 		}
 	}
 
-	for _, prof := range o.profilers {
+	for i, prof := range o.profilers {
 		err = prof.Start(ctx)
 		if err != nil {
+			for _, ex := range o.exporters {
+				ex.Stop(ctx)
+			}
+			for _, prof = range o.profilers[:i] {
+				prof.Stop(ctx)
+			}
 			return err
 		}
 	}
@@ -264,4 +273,8 @@ func (o *observability) Stop(ctx context.Context) {
 	for _, ex := range o.exporters {
 		ex.Stop(ctx)
 	}
+
+	for _, prof := range o.profilers {
+		prof.Stop(ctx)
+	}
 }
diff --git a/internal/observability/profiler/profiler.go b/internal/observability/profiler/profiler.go
@@ -23,4 +23,5 @@ import (
 
 type Profiler interface {
 	Start(ctx context.Context) error
+	Stop(ctx context.Context)
 }
diff --git a/internal/observability/profiler/stackdriver/stackdriver.go b/internal/observability/profiler/stackdriver/stackdriver.go
@@ -51,3 +51,6 @@ func New(opts ...Option) (s Stackdriver, err error) {
 func (p *prof) Start(ctx context.Context) (err error) {
 	return profiler.Start(*p.Config, p.clientOpts...)
 }
+
+func (p *prof) Stop(ctx context.Context) {
+}