Fix code scanning alert no. 8914: Size computation for allocation may…

… overflow Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Yusuke Kato <[email protected]>
vdaas · Dec 9, 2024 · 8bb0c2f · 8bb0c2f
1 parent 00bf13b
commit 8bb0c2f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/hack/docker/gen/main.go b/hack/docker/gen/main.go
@@ -1023,10 +1023,10 @@ jobs:
 			// remove the double quotation marks from the generated key "on": (note that the word "on" is a reserved word in sigs.k8s.io/yaml)
 			workflowYaml := strings.Replace(string(workflowYamlTmp), "\"on\":", "on:", 1)
 
-			totalLen := len(header) + len(workflowYaml)
-			if totalLen < len(header) || totalLen < len(workflowYaml) {
+			if len(header) > (int(^uint(0) >> 1) - len(workflowYaml)) {
 				return fmt.Errorf("size computation for allocation may overflow")
 			}
+			totalLen := len(header) + len(workflowYaml)
 
 			buf := bytes.NewBuffer(make([]byte, 0, totalLen))
 			err = license.Execute(buf, data)