-
Notifications
You must be signed in to change notification settings - Fork 78
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add index correction internal logic (#2194)
* implement the initail framework * add corrector configuration * add corrector logic * add build make command for index correction binary * add Dockerfile for index correction * add Docker image for index job correction * add timer * fix tag align * tmp * fix log * temporally implement two versions of correct function * set eg limit from config * add stream list concurrency config * implement index id caching * add config to use cache or not * style: Format code with prettier and gofumpt * refactor availableAddrs * add kvs range duration * add leftAgentAddrs for performance * Revert "add kvs range duration" This reverts commit 5b647be. * refactor * fix without cache bug * enable observability * refactor * SIGTERM after complete * add metrics server * add pcache * remove comment * [TEMP] use pcache * [TMP] use pcache * fix empty shard returns error * fix to use local map * [TMP] add prestop for pcache * [TEMP] add pcache config * style: Format code with prettier and gofumpt * [TEMP] add pcache log * fix map alloc size * [TMP] Add bbolt cache * update bbolt * fix bbolt bug * add bbolt test * [TEMP] use bbolt as persistent cache * style: Format code with prettier and gofumpt * add SetBatch to bbolt * use batch to write map to disk * style: Format code with prettier and gofumpt * delete the map elements on finalize * manually call GC after the map shrink * add limit to SetBatch goroutine number * stop unnecesarry GC * increase eg limit to the MaxBatchSize * use ch to set batch bbolt * fix servers shutdown properly * use internal/kvs/bbolt * refactor * always use bbolt cache for correction * update sample.yaml for correction * style: format code with Prettier and Gofumpt This commit fixes the style issues introduced in 319ec8b according to the output from Prettier and Gofumpt. Details: #2152 * use go std slices pkg * refactor * add comment * remove valdsync * use vald errgroup * refactor * Define ErrNoAvailableAgentToInsert * update comment in English * Apply new actions yaml format * Disable godox * style: format code with Prettier and Gofumpt This commit fixes the style issues introduced in c860ddc according to the output from Prettier and Gofumpt. Details: #2194 * remove comment * Apply format * Add type check for type assertion * use const to specify filemode * Add bbolt concurrency as config * fix var style * Suppress linter * fix comment * add test template * Refactor parameters for index correction * Refactor config * Add corrector test * style: format code with Prettier and Gofumpt This commit fixes the style issues introduced in 004bf81 according to the output from Prettier and Gofumpt. Details: #2194 * Add timestamp check * Apply format * fix schema type * Fix DeepSource errors * Fix misspell * Add type check * Remove unused config * Fix DeepSource error * Add required go:build e2e tag * Remove memo * Refactor comment * Remove TODO comment that is already done * Remove unused config * Add comment to errors * change app name * replace filepath pkg with internal file replace filepath pkg with internal file refactor * Refactor refactor * Fix gRPC spelling * Remove memo --------- Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
- Loading branch information
Showing
22 changed files
with
3,103 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| # | ||
| # Copyright (C) 2019-2023 vdaas.org vald team <[email protected]> | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # You may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
| name: "Build docker image: index-correction" | ||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| tags: | ||
| - "*.*.*" | ||
| - "v*.*.*" | ||
| - "*.*.*-*" | ||
| - "v*.*.*-*" | ||
| paths: | ||
| - ".github/actions/docker-build/actions.yaml" | ||
| - ".github/workflows/dockers-index-correction.yml" | ||
| - "go.mod" | ||
| - "go.sum" | ||
| - "internal/**" | ||
| - "!internal/**/*_test.go" | ||
| - "!internal/db/**" | ||
| - "!internal/k8s/**" | ||
| - "apis/grpc/**" | ||
| - "pkg/index/job/correction/**" | ||
| - "cmd/index/job/correction/**" | ||
| - "dockers/index/job/correction/Dockerfile" | ||
| - "versions/GO_VERSION" | ||
| pull_request: | ||
| paths: | ||
| - ".github/actions/docker-build/actions.yaml" | ||
| - ".github/workflows/_docker-image.yaml" | ||
| - ".github/workflows/dockers-index-correction.yml" | ||
| - "go.mod" | ||
| - "go.sum" | ||
| - "internal/**" | ||
| - "!internal/**/*_test.go" | ||
| - "!internal/db/**" | ||
| - "!internal/k8s/**" | ||
| - "apis/grpc/**" | ||
| - "pkg/index/job/correction/**" | ||
| - "cmd/index/job/correction/**" | ||
| - "dockers/index/job/correction/Dockerfile" | ||
| - "versions/GO_VERSION" | ||
| pull_request_target: | ||
| paths: | ||
| - ".github/actions/docker-build/actions.yaml" | ||
| - ".github/workflows/_docker-image.yaml" | ||
| - ".github/workflows/dockers-index-correction.yml" | ||
| - "go.mod" | ||
| - "go.sum" | ||
| - "internal/**" | ||
| - "!internal/**/*_test.go" | ||
| - "!internal/db/**" | ||
| - "!internal/k8s/**" | ||
| - "apis/grpc/**" | ||
| - "pkg/index/job/correction/**" | ||
| - "cmd/index/job/correction/**" | ||
| - "dockers/index/job/correction/Dockerfile" | ||
| - "versions/GO_VERSION" | ||
|
|
||
| jobs: | ||
| build: | ||
| uses: ./.github/workflows/_docker-image.yaml | ||
| with: | ||
| target: index-correction | ||
| secrets: inherit |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| // Copyright (C) 2019-2023 vdaas.org vald team <[email protected]> | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // You may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // https://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| package main | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "github.com/vdaas/vald/internal/errors" | ||
| "github.com/vdaas/vald/internal/info" | ||
| "github.com/vdaas/vald/internal/log" | ||
| "github.com/vdaas/vald/internal/runner" | ||
| "github.com/vdaas/vald/internal/safety" | ||
| "github.com/vdaas/vald/pkg/index/job/correction/config" | ||
| "github.com/vdaas/vald/pkg/index/job/correction/usecase" | ||
| ) | ||
|
|
||
| const ( | ||
| maxVersion = "v0.0.10" | ||
| minVersion = "v0.0.0" | ||
| name = "index correction job" | ||
| ) | ||
|
|
||
| func main() { | ||
| if err := safety.RecoverFunc(func() error { | ||
| return runner.Do( | ||
| context.Background(), | ||
| runner.WithName(name), | ||
| runner.WithVersion(info.Version, maxVersion, minVersion), | ||
| runner.WithConfigLoader(func(path string) (interface{}, *config.GlobalConfig, error) { | ||
| cfg, err := config.NewConfig(path) | ||
| if err != nil { | ||
| return nil, nil, errors.Wrap(err, "failed to load "+name+"'s configuration") | ||
| } | ||
| return cfg, &cfg.GlobalConfig, nil | ||
| }), | ||
| runner.WithDaemonInitializer(func(cfg interface{}) (runner.Runner, error) { | ||
| c, ok := cfg.(*config.Data) | ||
| if !ok { | ||
| return nil, errors.ErrInvalidConfig | ||
| } | ||
| return usecase.New(c) | ||
| }), | ||
| ) | ||
| })(); err != nil { | ||
| log.Fatal(err, info.Get()) | ||
| return | ||
| } | ||
| } |
Oops, something went wrong.